linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: matti.vaittinen@fi.rohmeurope.com (Matti Vaittinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/8] clk: clkdev/of_clk - add managed lookup and provider registrations
Date: Wed, 31 Oct 2018 15:48:47 +0200	[thread overview]
Message-ID: <20181031134847.GA29664@localhost.localdomain> (raw)
In-Reply-To: <b3954431df109827c71d25d390adf22f6991a6df.1540970653.git.matti.vaittinen@fi.rohmeurope.com>

On Wed, Oct 31, 2018 at 10:30:34AM +0200, Matti Vaittinen wrote:
> With MFD devices the clk properties may be contained in MFD (parent) DT
> node. Current devm_of_clk_add_hw_provider assumes the clk is bound to MFD
> subdevice not to MFD device (parent). Add
> devm_of_clk_add_hw_provider_parent to tackle this issue.
> 
> Also clkdev registration lacks of managed registration functions and it
> seems few drivers do not drop clkdev lookups at exit. Add
> devm_clk_hw_register_clkdev and devm_clk_release_clkdev to ease lookup
> releasing at exit.
> 
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>

//snip

> diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
> index 60c51871b04b..94c7bf471c31 100644
> --- a/include/linux/clk-provider.h
> +++ b/include/linux/clk-provider.h
> @@ -916,6 +916,10 @@ int devm_of_clk_add_hw_provider(struct device *dev,
>  			   struct clk_hw *(*get)(struct of_phandle_args *clkspec,
>  						 void *data),
>  			   void *data);
> +int devm_of_clk_add_parent_hw_provider(struct device *dev,
> +			   struct clk_hw *(*get)(struct of_phandle_args *clkspec,
> +						 void *data),
> +			   void *data);
>  void of_clk_del_provider(struct device_node *np);
>  void devm_of_clk_del_provider(struct device *dev);
>  struct clk *of_clk_src_simple_get(struct of_phandle_args *clkspec,

Right. Didn't spot the 
#ifdef CONFIG_OF
in clk-provider.h. So patch lacks of stub functions for non OF
architectures. The 0-Day test system spot this. Tomorrow I'll send v2
where the inlined stub functions for non OF architectures are added.

Br,
	Matti Vaittinen

-- 
Matti Vaittinen
ROHM Semiconductors

~~~ "I don't think so," said Rene Descartes.  Just then, he vanished ~~~

  reply	other threads:[~2018-10-31 13:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-31  8:29 [PATCH 0/8] clk: clkdev: managed clk lookup and provider registrations Matti Vaittinen
2018-10-31  8:30 ` [PATCH 1/8] clk: clkdev/of_clk - add managed " Matti Vaittinen
2018-10-31 13:48   ` Matti Vaittinen [this message]
2018-10-31  8:31 ` [PATCH 2/8] clk: clk-max77686: Clean clkdev lookup leak and use devm Matti Vaittinen
2018-10-31  8:31 ` [PATCH 3/8] clk: clk-s3c2410-dclk: clean up clkdev lookup leak Matti Vaittinen
2018-10-31  8:32 ` [PATCH 4/8] clk: clk-st: avoid clkdev lookup leak at remove Matti Vaittinen
2018-10-31  8:32 ` [PATCH 5/8] clk: clk-hi655x: Free of_provider " Matti Vaittinen
2018-10-31  8:33 ` [PATCH 6/8] clk: rk808: use managed version of of_provider registration Matti Vaittinen
2018-10-31  8:34 ` [PATCH 7/8] clk: clk-twl6040: Free of_provider at remove Matti Vaittinen
2018-10-31 13:24   ` kbuild test robot
2018-10-31 14:26   ` kbuild test robot
2018-10-31  8:34 ` [PATCH 8/8] clk: apcs-msm8916: simplify probe cleanup by using devm Matti Vaittinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181031134847.GA29664@localhost.localdomain \
    --to=matti.vaittinen@fi.rohmeurope.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).