* [PATCH] i2c: rk3x: fix some typo @ 2018-11-01 15:37 Yangtao Li 2018-11-01 15:56 ` Heiko Stübner 0 siblings, 1 reply; 3+ messages in thread From: Yangtao Li @ 2018-11-01 15:37 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/i2c/busses/i2c-rk3x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c index b8a2728dd4b6..fe347e8e2a23 100644 --- a/drivers/i2c/busses/i2c-rk3x.c +++ b/drivers/i2c/busses/i2c-rk3x.c @@ -555,7 +555,7 @@ static const struct i2c_spec_values *rk3x_i2c_get_spec(unsigned int speed) * * @clk_rate: I2C input clock rate * @t: Known I2C timing information - * @t_calc: Caculated rk3x private timings that would be written into regs + * @t_calc: Calculated rk3x private timings that would be written into regs * * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case * a best-effort divider value is returned in divs. If the target rate is @@ -716,7 +716,7 @@ static int rk3x_i2c_v0_calc_timings(unsigned long clk_rate, * * @clk_rate: I2C input clock rate * @t: Known I2C timing information - * @t_calc: Caculated rk3x private timings that would be written into regs + * @t_calc: Calculated rk3x private timings that would be written into regs * * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that case * a best-effort divider value is returned in divs. If the target rate is -- 2.17.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] i2c: rk3x: fix some typo 2018-11-01 15:37 [PATCH] i2c: rk3x: fix some typo Yangtao Li @ 2018-11-01 15:56 ` Heiko Stübner 2018-11-01 16:18 ` Frank Lee 0 siblings, 1 reply; 3+ messages in thread From: Heiko Stübner @ 2018-11-01 15:56 UTC (permalink / raw) To: linux-arm-kernel Hi, Am Donnerstag, 1. November 2018, 16:37:49 CET schrieb Yangtao Li: > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> while the changes really are pretty self-explanatory, it is always nice to describe changes in a real commit message, like Fix multiple instances of a misspelled "Calculates". Change itself looks good, so Reviewed-by: Heiko Stuebner <heiko@sntech.de> Thanks Heiko > --- > drivers/i2c/busses/i2c-rk3x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c > index b8a2728dd4b6..fe347e8e2a23 100644 > --- a/drivers/i2c/busses/i2c-rk3x.c > +++ b/drivers/i2c/busses/i2c-rk3x.c > @@ -555,7 +555,7 @@ static const struct i2c_spec_values > *rk3x_i2c_get_spec(unsigned int speed) * > * @clk_rate: I2C input clock rate > * @t: Known I2C timing information > - * @t_calc: Caculated rk3x private timings that would be written into regs > + * @t_calc: Calculated rk3x private timings that would be written into regs > * > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that > case * a best-effort divider value is returned in divs. If the target rate > is @@ -716,7 +716,7 @@ static int rk3x_i2c_v0_calc_timings(unsigned long > clk_rate, * > * @clk_rate: I2C input clock rate > * @t: Known I2C timing information > - * @t_calc: Caculated rk3x private timings that would be written into regs > + * @t_calc: Calculated rk3x private timings that would be written into regs > * > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that > case * a best-effort divider value is returned in divs. If the target rate > is ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] i2c: rk3x: fix some typo 2018-11-01 15:56 ` Heiko Stübner @ 2018-11-01 16:18 ` Frank Lee 0 siblings, 0 replies; 3+ messages in thread From: Frank Lee @ 2018-11-01 16:18 UTC (permalink / raw) To: linux-arm-kernel >Hi, > >Am Donnerstag, 1. November 2018, 16:37:49 CET schrieb Yangtao Li: >> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > >while the changes really are pretty self-explanatory, it is always >nice to describe changes in a real commit message, like > >Fix multiple instances of a misspelled "Calculates". > >Change itself looks good, so >Reviewed-by: Heiko Stuebner <heiko@sntech.de> > > >Thanks Yeah,this is my fault. --Yangtao Li On Thu, Nov 1, 2018 at 11:56 PM Heiko St?bner <heiko@sntech.de> wrote: > > Hi, > > Am Donnerstag, 1. November 2018, 16:37:49 CET schrieb Yangtao Li: > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > while the changes really are pretty self-explanatory, it is always > nice to describe changes in a real commit message, like > > Fix multiple instances of a misspelled "Calculates". > > Change itself looks good, so > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > > > Thanks > Heiko > > > --- > > drivers/i2c/busses/i2c-rk3x.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c > > index b8a2728dd4b6..fe347e8e2a23 100644 > > --- a/drivers/i2c/busses/i2c-rk3x.c > > +++ b/drivers/i2c/busses/i2c-rk3x.c > > @@ -555,7 +555,7 @@ static const struct i2c_spec_values > > *rk3x_i2c_get_spec(unsigned int speed) * > > * @clk_rate: I2C input clock rate > > * @t: Known I2C timing information > > - * @t_calc: Caculated rk3x private timings that would be written into regs > > + * @t_calc: Calculated rk3x private timings that would be written into regs > > * > > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that > > case * a best-effort divider value is returned in divs. If the target rate > > is @@ -716,7 +716,7 @@ static int rk3x_i2c_v0_calc_timings(unsigned long > > clk_rate, * > > * @clk_rate: I2C input clock rate > > * @t: Known I2C timing information > > - * @t_calc: Caculated rk3x private timings that would be written into regs > > + * @t_calc: Calculated rk3x private timings that would be written into regs > > * > > * Returns: 0 on success, -EINVAL if the goal SCL rate is too slow. In that > > case * a best-effort divider value is returned in divs. If the target rate > > is > > > > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-01 16:18 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-11-01 15:37 [PATCH] i2c: rk3x: fix some typo Yangtao Li 2018-11-01 15:56 ` Heiko Stübner 2018-11-01 16:18 ` Frank Lee
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).