From: matti.vaittinen@fi.rohmeurope.com (Matti Vaittinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/8] clk: clk-s3c2410-dclk: clean up clkdev lookup leak
Date: Fri, 2 Nov 2018 11:18:25 +0200 [thread overview]
Message-ID: <20181102091825.GB29664@localhost.localdomain> (raw)
In-Reply-To: <CAJKOXPeM18c3a2nWeGGGw+Fn-GQ2C0ridwE3eqRsd1gVQ6zB5w@mail.gmail.com>
Thanks Krzysztof!
On Fri, Nov 02, 2018 at 09:19:10AM +0100, Krzysztof Kozlowski wrote:
> On Thu, 1 Nov 2018 at 08:19, Matti Vaittinen
> <matti.vaittinen@fi.rohmeurope.com> wrote:
> >
> > Use devm variant of clkdev lookup registration in order to avoid
> > clkdev lookup leak at device remove.
> >
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> > ---
> > drivers/clk/samsung/clk-s3c2410-dclk.c | 15 ++++++++-------
> > 1 file changed, 8 insertions(+), 7 deletions(-)
>
> Driver has suppress_bind_attrs and it cannot be built as module so
> device removal should not be possible. There is no need to use devm.
This is exactly what I wanted to hear =) I will drop this patch from
series.
--
Matti Vaittinen
ROHM Semiconductors
~~~ "I don't think so," said Rene Descartes. Just then, he vanished ~~~
next prev parent reply other threads:[~2018-11-02 9:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 7:17 [PATCH v2 0/8] clk: clkdev: managed clk lookup and provider registrations Matti Vaittinen
2018-11-01 7:18 ` [PATCH v2 1/8] clk: clkdev/of_clk - add managed " Matti Vaittinen
2018-11-01 7:18 ` [PATCH v2 2/8] clk: clk-max77686: Clean clkdev lookup leak and use devm Matti Vaittinen
2018-11-02 8:15 ` Krzysztof Kozlowski
2018-11-02 11:04 ` Matti Vaittinen
2018-11-01 7:19 ` [PATCH v2 3/8] clk: clk-s3c2410-dclk: clean up clkdev lookup leak Matti Vaittinen
2018-11-02 8:19 ` Krzysztof Kozlowski
2018-11-02 9:18 ` Matti Vaittinen [this message]
2018-11-01 7:19 ` [PATCH v2 4/8] clk: clk-st: avoid clkdev lookup leak at remove Matti Vaittinen
2018-11-01 7:20 ` [PATCH v2 5/8] clk: clk-hi655x: Free of_provider " Matti Vaittinen
2018-11-01 7:20 ` [PATCH v2 6/8] clk: rk808: use managed version of of_provider registration Matti Vaittinen
2018-11-01 7:21 ` [PATCH v2 7/8] clk: clk-twl6040: Free of_provider at remove Matti Vaittinen
2018-11-01 7:21 ` [PATCH v2 8/8] clk: apcs-msm8916: simplify probe cleanup by using devm Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181102091825.GB29664@localhost.localdomain \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox