From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: fix commit style in the comments
Date: Wed, 7 Nov 2018 09:18:55 +0000 [thread overview]
Message-ID: <20181107091855.ps5pumxp7djtfz3k@localhost> (raw)
In-Reply-To: <1541605151-6757-1-git-send-email-peng.hao2@zte.com.cn>
On Wed, Nov 07, 2018 at 11:39:11PM +0800, Peng Hao wrote:
> Use git commit description style 'commit <12+ chars of sha1>
> ("<title line>")' in the comments.
>
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> ---
> arch/arm64/kernel/sys32.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/kernel/sys32.c b/arch/arm64/kernel/sys32.c
> index 0f8bcb7..8317a5a 100644
> --- a/arch/arm64/kernel/sys32.c
> +++ b/arch/arm64/kernel/sys32.c
> @@ -40,8 +40,8 @@
> * arbitrary binaries may rely upon it, so we must do the same.
> * For more details, see commit:
> *
> - * 713c481519f19df9 ("[ARM] 3108/2: old ABI compat: statfs64 and
> - * fstatfs64")
> + * commit 713c481519f19df9 ("[ARM] 3108/2: old ABI compat: statfs64
> + * and fstatfs64")
Seriously, how does this help? It already states "see commit:" on the
previous line.
--
Catalin
prev parent reply other threads:[~2018-11-07 9:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 15:39 [PATCH] arm64: fix commit style in the comments Peng Hao
2018-11-07 9:18 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181107091855.ps5pumxp7djtfz3k@localhost \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox