From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/7] arm64: Add fast-path for stack alignment
Date: Wed, 7 Nov 2018 21:59:12 +0000 [thread overview]
Message-ID: <20181107215911.GF12248@brain-police> (raw)
In-Reply-To: <1537970184-44348-5-git-send-email-julien.thierry@arm.com>
On Wed, Sep 26, 2018 at 02:56:21PM +0100, Julien Thierry wrote:
> Avoiding stack alignment for already aligned stack can give a small
> performance boost.
>
> Branch out of the aligning code when the stack is known to be aligned.
>
> Signed-off-by: Julien Thierry <julien.thierry@arm.com>
> ---
> arch/arm64/kernel/entry.S | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S
> index 8fb66e4..bd8d52c 100644
> --- a/arch/arm64/kernel/entry.S
> +++ b/arch/arm64/kernel/entry.S
> @@ -61,6 +61,10 @@
>
> .macro force_stack_align
> xchg_sp x0
> +
> + tst x0, #0xf
> + b.eq 0f
> +
> str x1, [x0] // store x1 far away from S_SP
>
> // aligned_sp[S_SP] = old_sp
> @@ -69,6 +73,11 @@
>
> ldr x1, [x0]
> bic x0, x0, #0xf // x0 = aligned_sp
> + b 1f
> +
> +0:
> + str x0, [x0, #S_SP]
> +1:
I couldn't figure out a better way to do this, but please remove the empty
lines that you're adding here. With that:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
next prev parent reply other threads:[~2018-11-07 21:59 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 13:56 [PATCH 0/7] Ensure stack is aligned for kernel entries Julien Thierry
2018-09-26 13:56 ` [PATCH 1/7] arm64: Add static check for pt_regs alignment Julien Thierry
2018-11-07 21:58 ` Will Deacon
2018-11-08 10:16 ` Mark Rutland
2018-11-08 11:57 ` Julien Thierry
2018-11-08 16:53 ` Will Deacon
2018-11-08 18:35 ` Ard Biesheuvel
2018-09-26 13:56 ` [PATCH 2/7] arm64: sdei: Always use sdei stack for sdei events Julien Thierry
2018-11-07 21:58 ` Will Deacon
2018-11-21 11:15 ` James Morse
2018-09-26 13:56 ` [PATCH 3/7] arm64: Align stack when taking exception from EL1 Julien Thierry
2018-11-07 21:59 ` Will Deacon
2018-11-08 12:20 ` Julien Thierry
2018-09-26 13:56 ` [PATCH 4/7] arm64: Add fast-path for stack alignment Julien Thierry
2018-11-07 21:59 ` Will Deacon [this message]
2018-11-08 12:21 ` Julien Thierry
2018-09-26 13:56 ` [PATCH 5/7] arm64: Do not apply BP hardening for hyp entries from EL2 Julien Thierry
2018-11-07 21:59 ` Will Deacon
2018-11-08 12:23 ` Julien Thierry
2018-09-26 13:56 ` [PATCH 6/7] arm64: Do not apply vector harderning " Julien Thierry
2018-11-07 21:59 ` Will Deacon
2018-11-08 12:31 ` Julien Thierry
2018-09-26 13:56 ` [PATCH 7/7] arm64: kvm: Align stack for exception coming " Julien Thierry
2018-10-19 8:07 ` [PATCH 0/7] Ensure stack is aligned for kernel entries Julien Thierry
2018-11-07 21:58 ` Will Deacon
2018-11-08 12:43 ` Julien Thierry
2018-11-08 13:04 ` Ard Biesheuvel
2018-11-08 13:27 ` Julien Thierry
2018-11-08 14:10 ` Ard Biesheuvel
2018-11-08 14:19 ` Ramana Radhakrishnan
2018-11-08 15:01 ` Julien Thierry
2018-11-08 15:33 ` Ramana Radhakrishnan
2018-11-08 15:41 ` Julien Thierry
2018-11-08 15:30 ` Dave Martin
2018-11-08 15:33 ` Ramana Radhakrishnan
2018-11-08 15:39 ` Dave Martin
2018-11-08 15:44 ` Ard Biesheuvel
2018-11-08 16:57 ` Ramana Radhakrishnan
2018-11-08 17:14 ` Ard Biesheuvel
2018-11-22 11:49 ` Julien Thierry
2018-11-22 12:11 ` Ard Biesheuvel
2018-11-22 15:10 ` Julien Thierry
2018-11-22 15:12 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181107215911.GF12248@brain-police \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).