From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.brezillon@bootlin.com (Boris Brezillon) Date: Thu, 15 Nov 2018 14:09:05 +0100 Subject: [PATCH v6 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller In-Reply-To: <20181115140400.3934effe@xps13> References: <1541090542-19618-1-git-send-email-jianxin.pan@amlogic.com> <1541090542-19618-3-git-send-email-jianxin.pan@amlogic.com> <20181105165321.7ea2b45f@bbrezillon> <20181106102851.61deb97a@bbrezillon> <20181106112206.65a70a81@bbrezillon> <20181112171351.4ac3506b@xps13> <20181112175416.247e3203@bbrezillon> <20181112184518.6c02ac6d@bbrezillon> <27769252-ac5e-e787-6792-d6a06e7af0e4@amlogic.com> <20181115140400.3934effe@xps13> Message-ID: <20181115140905.40011b4b@bbrezillon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 15 Nov 2018 14:04:00 +0100 Miquel Raynal wrote: > Hi Liang, > > Liang Yang wrote on Thu, 15 Nov 2018 19:25:07 > +0800: > > > Hi Boris, > > > > I have implemented dma access base on these helpers you provided below. > > we prepare to send v7 version now, so when will these helpers be pushed? > > Thanks for your work. You can send the v7 so we will have a look at the > overall driver; but since we raised the DMA buffers issue we had a > discussion with Boris about how to handle them and I think we are going > to adopt the same solution as Wolfram in the I2C subsystem: manual > flagging. Sadly, this is probably the best we can do to ensure proper > DMA support. > > There is nothing set is stone yet but I started a small rework to > handle MTD operations differently (and add a DMA_SAFE flag), you can > have a look there [1]. Don't base your work on it for now as it is just > a preliminary version, subject to big changes. In order to not block the driver, I'd suggest that you move the helper I proposed directly into your driver and prefix them with 'meson_'.