From: andriy.shevchenko@linux.intel.com (Andy Shevchenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: Add (devm_)clk_get_optional() functions
Date: Tue, 20 Nov 2018 12:38:33 +0200 [thread overview]
Message-ID: <20181120103832.GV10650@smile.fi.intel.com> (raw)
In-Reply-To: <20181119141259.11992-1-phil.edworthy@renesas.com>
On Mon, Nov 19, 2018 at 02:12:59PM +0000, Phil Edworthy wrote:
> This adds clk_get_optional() and devm_clk_get_optional() functions to get
> optional clocks.
> They behave the same as (devm_)clk_get except where there is no clock
> producer. In this case, instead of returning -ENOENT, the function
> returns NULL. This makes error checking simpler and allows
> clk_prepare_enable, etc to be called on the returned reference
> without additional checks.
> - Instead of messing with the core functions, simply wrap them for the
> _optional() versions. By putting clk_get_optional() inline in the header
> file, we can get rid of the arch specific patches as well.
Fine if it would have no surprises with error handling.
> + if (ERR_PTR(-ENOENT))
> + return NULL;
> + else
> + return clk;
return clk == ERR_PTR(-ENOENT) ? NULL : clk;
?
> + if (clk == ERR_PTR(-ENOENT))
> + return NULL;
> + else
> + return clk;
Ditto.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-11-20 10:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 14:12 [PATCH] clk: Add (devm_)clk_get_optional() functions Phil Edworthy
2018-11-20 10:38 ` Andy Shevchenko [this message]
2018-11-20 10:53 ` Phil Edworthy
2018-11-20 11:12 ` Andy Shevchenko
2018-11-20 12:56 ` Uwe Kleine-König
2018-11-20 13:26 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120103832.GV10650@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).