From: mathieu.poirier@linaro.org (Mathieu Poirier)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/3] coresight: etmv4: Update ID register table to add UCI support
Date: Tue, 20 Nov 2018 13:59:07 -0700 [thread overview]
Message-ID: <20181120205907.GB17267@xps15> (raw)
In-Reply-To: <20181115012842.2353-3-mike.leach@linaro.org>
On Thu, Nov 15, 2018 at 01:28:41AM +0000, Mike Leach wrote:
> Updates the ID register tables to contain a UCI entry for the A35 ETM
> device to allow correct matching of driver in the amba bus code.
>
> Signed-off-by: Mike Leach <mike.leach@linaro.org>
> ---
> drivers/hwtracing/coresight/coresight-etm4x.c | 26 +++++++++++++++----
> 1 file changed, 21 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c
> index 53e2fb6e86f6..1dcb7e14ea6b 100644
> --- a/drivers/hwtracing/coresight/coresight-etm4x.c
> +++ b/drivers/hwtracing/coresight/coresight-etm4x.c
> @@ -1073,12 +1073,28 @@ static int etm4_probe(struct amba_device *adev, const struct amba_id *id)
> .mask = 0x000fffff, \
> }
>
> +static struct amba_cs_uci_id uci_id_etm4[] = {
> + {
> + /* ETMv4 UCI data */
> + .devarch = 0x00004a13,
> + .mask = 0x0000ffff,
> + .devtype = 0x00000013,
> + }
> +};
> +
> +#define ETM4x_AMBA_UCI_ID(pid) \
> + { \
> + .id = pid, \
> + .mask = 0x000fffff, \
> + .data = uci_id_etm4, \
> + }
> +
> static const struct amba_id etm4_ids[] = {
> - ETM4x_AMBA_ID(0x000bb95d), /* Cortex-A53 */
> - ETM4x_AMBA_ID(0x000bb95e), /* Cortex-A57 */
> - ETM4x_AMBA_ID(0x000bb95a), /* Cortex-A72 */
> - ETM4x_AMBA_ID(0x000bb959), /* Cortex-A73 */
> - ETM4x_AMBA_ID(0x000bb9da), /* Cortex-A35 */
> + ETM4x_AMBA_ID(0x000bb95d), /* Cortex-A53 */
> + ETM4x_AMBA_ID(0x000bb95e), /* Cortex-A57 */
> + ETM4x_AMBA_ID(0x000bb95a), /* Cortex-A72 */
> + ETM4x_AMBA_ID(0x000bb959), /* Cortex-A73 */
There is no need to add the extra tabulation for the above.
> + ETM4x_AMBA_UCI_ID(0x000bb9da), /* Cortex-A35 */
> {},
> };
>
> --
> 2.19.1
>
next prev parent reply other threads:[~2018-11-20 20:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 1:28 [RFC PATCH 0/3] Update AMBA driver for enhanced component ID spec Mike Leach
2018-11-15 1:28 ` [RFC PATCH 1/3] drivers: amba: Updates to component identification for driver matching Mike Leach
2018-11-19 14:55 ` Suzuki K Poulose
2018-11-20 10:47 ` Mike Leach
2018-11-20 20:57 ` Mathieu Poirier
2018-11-21 11:09 ` Mike Leach
2018-11-21 14:25 ` Al Grant
2018-11-21 15:53 ` Mike Leach
2018-11-21 16:23 ` Al Grant
2018-11-15 1:28 ` [RFC PATCH 2/3] coresight: etmv4: Update ID register table to add UCI support Mike Leach
2018-11-20 20:59 ` Mathieu Poirier [this message]
2018-11-21 15:57 ` Mike Leach
2018-11-15 1:28 ` [RFC PATCH 3/3] amba: coresight: Driver test for new CoreSight UCI matching Mike Leach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181120205907.GB17267@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox