linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
To: linux-arm-kernel@lists.infradead.org
Subject: remove the ->mapping_error method from dma_map_ops V2
Date: Fri, 23 Nov 2018 07:57:20 +0100	[thread overview]
Message-ID: <20181123065720.GB17856@lst.de> (raw)
In-Reply-To: <20181122180526.GL30658@n2100.armlinux.org.uk>

On Thu, Nov 22, 2018 at 06:05:26PM +0000, Russell King - ARM Linux wrote:
> An alternative idea would be to migrate away from the
> dma_map_single() and dma_map_page() interfaces that return a
> dma_addr_t, and instead have them return an error code or zero
> on success.

See here for a proposal:

https://lists.linuxfoundation.org/pipermail/iommu/2018-November/030912.html

That is just the attr variants, but that would be a start.  Dave didn't
particularly like it, though.

> note the simpler unmap API, which inherently guarantees that the
> parameters to the map could be carried over to the unmap - without
> our many driver authors having to think about it.

The problem is that we can often derive some or all parameters from
field already inherent in the upper layer or hardware interface.  So
for these cases your version would bloat the required data structures.

  reply	other threads:[~2018-11-23  6:57 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-22 14:02 remove the ->mapping_error method from dma_map_ops V2 Christoph Hellwig
2018-11-22 14:02 ` [PATCH 01/24] dma-direct: Make DIRECT_MAPPING_ERROR viable for SWIOTLB Christoph Hellwig
2018-11-22 14:02 ` [PATCH 02/24] swiotlb: Skip cache maintenance on map error Christoph Hellwig
2018-11-22 14:02 ` [PATCH 03/24] dma-mapping: provide a generic DMA_MAPPING_ERROR Christoph Hellwig
2018-11-22 14:03 ` [PATCH 04/24] dma-direct: remove the mapping_error dma_map_ops method Christoph Hellwig
2018-11-22 14:03 ` [PATCH 05/24] arm: " Christoph Hellwig
2018-11-22 14:03 ` [PATCH 06/24] powerpc/iommu: " Christoph Hellwig
2018-11-22 14:03 ` [PATCH 07/24] mips/jazz: " Christoph Hellwig
2018-11-22 14:03 ` [PATCH 08/24] s390: " Christoph Hellwig
2018-11-22 14:03 ` [PATCH 09/24] sparc: " Christoph Hellwig
2018-11-22 14:03 ` [PATCH 10/24] parisc/ccio: " Christoph Hellwig
2018-11-22 14:03 ` [PATCH 11/24] parisc/sba_iommu: " Christoph Hellwig
2018-11-22 14:03 ` [PATCH 12/24] arm64: remove the dummy_dma_ops mapping_error method Christoph Hellwig
2018-11-22 14:03 ` [PATCH 13/24] alpha: remove the mapping_error dma_map_ops method Christoph Hellwig
2018-11-22 14:03 ` [PATCH 14/24] ia64/sba_iommu: improve internal map_page users Christoph Hellwig
2018-11-22 14:03 ` [PATCH 15/24] ia64/sba_iommu: remove the mapping_error dma_map_ops method Christoph Hellwig
2018-11-22 14:03 ` [PATCH 16/24] ia64/sn: " Christoph Hellwig
2018-11-22 14:03 ` [PATCH 17/24] x86/amd_gart: " Christoph Hellwig
2018-11-22 14:03 ` [PATCH 18/24] x86/calgary: " Christoph Hellwig
2018-11-22 14:03 ` [PATCH 19/24] iommu: " Christoph Hellwig
2018-11-22 14:03 ` [PATCH 20/24] iommu/intel: small map_page cleanup Christoph Hellwig
2018-11-22 14:03 ` [PATCH 21/24] iommu/vt-d: remove the mapping_error dma_map_ops method Christoph Hellwig
2018-11-22 14:03 ` [PATCH 22/24] iommu/dma-iommu: " Christoph Hellwig
2018-11-22 14:03 ` [PATCH 23/24] xen-swiotlb: " Christoph Hellwig
2018-11-22 14:03 ` [PATCH 24/24] dma-mapping: " Christoph Hellwig
2018-11-22 16:50 ` remove the ->mapping_error method from dma_map_ops V2 Linus Torvalds
2018-11-22 17:07   ` Russell King - ARM Linux
2018-11-22 17:09     ` Linus Torvalds
2018-11-22 17:14       ` Russell King - ARM Linux
2018-11-22 17:52       ` Robin Murphy
2018-11-22 17:55         ` Linus Torvalds
2018-11-22 18:05           ` Russell King - ARM Linux
2018-11-23  6:57             ` Christoph Hellwig [this message]
2018-11-23  6:55           ` Christoph Hellwig
2018-11-28  7:41             ` Christoph Hellwig
2018-11-28 16:47               ` Linus Torvalds
2018-11-28 17:45                 ` Russell King - ARM Linux
2018-11-28 18:00                   ` Linus Torvalds
2018-11-28 18:08                     ` Russell King - ARM Linux
2018-11-28 19:23                       ` Russell King - ARM Linux
     [not found]                       ` <CAHk-=whcbiSxSUprsKjVPEdN5-+o8WnTGiKxEV-+HbKNDs=iNA@mail.gmail.com>
2018-11-28 19:31                         ` Russell King - ARM Linux
2018-11-29 16:23                         ` Christoph Hellwig
2018-11-29 17:44                           ` Linus Torvalds
2018-11-29 18:31                             ` Christoph Hellwig
2018-11-29 18:53                               ` Linus Torvalds
2018-11-29 18:55                                 ` Christoph Hellwig
2018-11-28 19:27                     ` David Miller
2018-11-28 19:47                       ` Russell King - ARM Linux
2018-11-28 23:01                         ` Shuah Khan
2018-11-23 10:49         ` Joerg Roedel
2018-11-23 11:01           ` Russell King - ARM Linux
2018-11-23 13:03             ` Joerg Roedel
2018-11-23 13:20               ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181123065720.GB17856@lst.de \
    --to=hch@lst.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).