[PATCH 3/5] media: sunxi: Add A10 CSI driver

Maxime Ripard
2018-11-15T20:51:06Z

Hi Hans,

Thanks for your review! I'll address the other comments you made.

On Tue, Nov 13, 2018 at 01:24:47PM +0100, Hans Verkuil wrote:
> > +static int csi_probe(struct platform_device *pdev)
> > +{
> > + struct sun4i_csi *csi;
> > + struct resource *res;
> > + int ret;
> > + int irq;
> > +
> > + csi = devm_kzalloc(&pdev->dev, sizeof(*csi), GFP_KERNEL);
>
> devm_kzalloc is not recommended: all devm_ memory is freed when the driver
> is unbound, but a filehandle might still have a reference open.

How would a !devm variant with a kfree in the remove help? We would
still fall in the same case, right?

Thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20181115/f7c42dde/attachment-0001.sig>