public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: bhe@redhat.com (Baoquan He)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] x86_64, vmcoreinfo: Append 'page_offset_base' to vmcoreinfo
Date: Wed, 28 Nov 2018 09:57:54 +0800	[thread overview]
Message-ID: <20181128015754.GI1824@MiWiFi-R3L-srv> (raw)
In-Reply-To: <CAGXu5jJzVMmqJ9JvFqDhDx=QShiWisWO0bY49cD5r-7By5dxFg@mail.gmail.com>

On 11/27/18 at 04:39pm, Kees Cook wrote:
> >> >> diff --git a/arch/x86/kernel/machine_kexec_64.c b/arch/x86/kernel/machine_kexec_64.c
> >> >> index 4c8acdfdc5a7..6161d77c5bfb 100644
> >> >> --- a/arch/x86/kernel/machine_kexec_64.c
> >> >> +++ b/arch/x86/kernel/machine_kexec_64.c
> >> >> @@ -356,6 +356,9 @@ void arch_crash_save_vmcoreinfo(void)
> >> >>       VMCOREINFO_SYMBOL(init_top_pgt);
> >> >>       vmcoreinfo_append_str("NUMBER(pgtable_l5_enabled)=%d\n",
> >> >>                       pgtable_l5_enabled());
> >> >> +#ifdef CONFIG_RANDOMIZE_BASE
> 
> Okay, gotcha. In that case, shouldn't this be CONFIG_RANDOMIZE_MEMORY?

And yes, if we only care about KASLR, it should be
CONFIG_RANDOMIZE_MEMORY, but not CONFIG_RANDOMIZE_BASE.

  parent reply	other threads:[~2018-11-28  1:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15 21:47 [PATCH v2] x86_64, vmcoreinfo: Append 'page_offset_base' to vmcoreinfo Bhupesh Sharma
2018-11-19 21:07 ` Kazuhito Hagio
2018-11-21  7:37   ` Bhupesh Sharma
2018-11-21 11:39 ` Borislav Petkov
2018-11-24 20:06   ` Bhupesh Sharma
2018-11-25 10:19     ` Baoquan He
2018-11-27 22:16   ` Kees Cook
2018-11-27 23:29     ` Baoquan He
2018-11-28  0:39       ` Kees Cook
2018-11-28  1:39         ` Baoquan He
2018-11-28  1:57         ` Baoquan He [this message]
2018-11-28  4:26           ` Bhupesh Sharma
2018-11-28 11:38   ` Dave Young
2018-11-26  1:28 ` Baoquan He
2018-11-26 19:31   ` Bhupesh Sharma
2018-11-27  6:48     ` Baoquan He
2018-11-27  7:15       ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181128015754.GI1824@MiWiFi-R3L-srv \
    --to=bhe@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox