From: alexandre.belloni@bootlin.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller RTC support
Date: Wed, 28 Nov 2018 10:19:43 +0100 [thread overview]
Message-ID: <20181128091943.GB8952@piout.net> (raw)
In-Reply-To: <DB3PR0402MB3916FFD700313BF684CF32AAF5D10@DB3PR0402MB3916.eurprd04.prod.outlook.com>
On 28/11/2018 09:06:27+0000, Anson Huang wrote:
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > index 9155d45..ef57db6 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> > > @@ -433,4 +433,8 @@
> > > #size-cells = <1>;
> > > ranges = <0x5f000000 0x0 0x5f000000 0x1000000>;
> > > };
> > > +
> > > + rtc: rtc {
> > > + compatible = "nxp,imx8qxp-sc-rtc";
> > > + };
> > > };
> > IMO this should be disabled by default.
>
> This module is NOT depending on any board design, should it be enabled by default in soc dtsi?
> Like wdog etc..
>
I guess the point is that you may not want it enabled, even if it should
always be working. enabling it by default would affect the RTC ordering
for example.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-11-28 9:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 9:41 [PATCH 0/4] Add i.MX system controller RTC driver Anson Huang
2018-11-27 9:41 ` [PATCH 1/4] rtc: add i.MX system controller RTC support Anson Huang
2018-11-27 21:35 ` Alexandre Belloni
2018-11-27 9:41 ` [PATCH 2/4] dt-bindings: rtc: add binding doc for i.MX system controller RTC driver Anson Huang
2018-11-27 21:26 ` Alexandre Belloni
2018-11-27 9:41 ` [PATCH 3/4] defconfig: arm64: add i.MX system controller RTC support Anson Huang
2018-11-27 21:36 ` Alexandre Belloni
2018-11-27 9:41 ` [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP " Anson Huang
2018-11-28 9:04 ` Lothar Waßmann
2018-11-28 9:06 ` Anson Huang
2018-11-28 9:12 ` Lothar Waßmann
2018-11-28 9:20 ` Anson Huang
2018-11-28 9:19 ` Alexandre Belloni [this message]
2018-11-28 9:21 ` Anson Huang
2018-11-28 9:33 ` Alexandre Belloni
2018-11-28 9:41 ` Anson Huang
2018-11-28 9:58 ` Alexandre Belloni
2018-11-28 10:03 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128091943.GB8952@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).