From mboxrd@z Thu Jan 1 00:00:00 1970 From: LW@KARO-electronics.de (Lothar =?UTF-8?B?V2HDn21hbm4=?=) Date: Wed, 28 Nov 2018 10:12:30 +0100 Subject: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller RTC support In-Reply-To: References: <1543311334-8807-1-git-send-email-Anson.Huang@nxp.com> <1543311334-8807-5-git-send-email-Anson.Huang@nxp.com> <20181128100420.0c9a721a@karo-electronics.de> Message-ID: <20181128101230.435bfbeb@ipc1.ka-ro> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Anson Huang wrote: > Hi, Lothar > > Best Regards! > Anson Huang > > > -----Original Message----- > > From: Lothar Wa?mann [mailto:LW at KARO-electronics.de] > > Sent: 2018?11?28? 17:04 > > To: Anson Huang > > Cc: a.zummo at towertech.it; alexandre.belloni at bootlin.com; > > robh+dt at kernel.org; mark.rutland at arm.com; catalin.marinas at arm.com; > > will.deacon at arm.com; Aisheng DONG ; Andy Gross > > ; arnd at arndb.de; horms+renesas at verge.net.au; > > heiko at sntech.de; bjorn.andersson at linaro.org; enric.balletbo at collabora.com; > > amit.kucheria at linaro.org; ezequiel at collabora.com; olof at lixom.net; > > shawnguo at kernel.org; linux-rtc at vger.kernel.org; devicetree at vger.kernel.org; > > linux-kernel at vger.kernel.org; linux-arm-kernel at lists.infradead.org; > > dl-linux-imx > > Subject: Re: [PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller > > RTC support > > > > Hi, > > > > On Tue, 27 Nov 2018 09:41:46 +0000 Anson Huang wrote: > > > Add i.MX8QXP system controller RTC support. > > > > > > Signed-off-by: Anson Huang > > > --- > > > arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > index 9155d45..ef57db6 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi > > > @@ -433,4 +433,8 @@ > > > #size-cells = <1>; > > > ranges = <0x5f000000 0x0 0x5f000000 0x1000000>; > > > }; > > > + > > > + rtc: rtc { > > > + compatible = "nxp,imx8qxp-sc-rtc"; > > > + }; > > > }; > > IMO this should be disabled by default. > > This module is NOT depending on any board design, should it be enabled by default in soc dtsi? > Like wdog etc.. > What about existing users (if there are any), which would have a new device appearing when updating the DTB? Lothar Wa?mann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Gesch?ftsf?hrer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info at karo-electronics.de ___________________________________________________________