From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@bootlin.com (Maxime Ripard) Date: Wed, 28 Nov 2018 16:43:03 +0100 Subject: [PATCH 58/77] ARM: dts: sun8i: a23/a33: Remove redundant MMC pinmux tuning In-Reply-To: References: <20181128135931.dpmuqpzz5wayucv3@flea> Message-ID: <20181128154303.rjqinarqlmyww7vq@flea> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Nov 28, 2018 at 10:30:55PM +0800, Chen-Yu Tsai wrote: > On Wed, Nov 28, 2018 at 9:59 PM Maxime Ripard wrote: > > On Wed, Nov 28, 2018 at 08:36:33PM +0800, Chen-Yu Tsai wrote: > > > On Tue, Nov 27, 2018 at 8:47 PM Maxime Ripard wrote: > > > > > > > > Some boards override the MMC pin muxing settings in order to enable the > > > > pull-ups and change the drive strength to a value higher than the default. > > > > > > > > While this was needed in the earlier days, this is now the default setting > > > > for those pins, and therefore we don't need those board-specific settings > > > > anymore. > > > > > > > > Signed-off-by: Maxime Ripard > > > > --- > > > > arch/arm/boot/dts/sun8i-a23-polaroid-mid2407pxe03.dts | 4 ---- > > > > arch/arm/boot/dts/sun8i-a23-polaroid-mid2809pxe04.dts | 4 ---- > > > > arch/arm/boot/dts/sun8i-a33-inet-d978-rev2.dts | 4 ---- > > > > arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts | 7 ------- > > > > arch/arm/boot/dts/sun8i-q8-common.dtsi | 4 ---- > > > > arch/arm/boot/dts/sun8i-r16-parrot.dts | 5 ----- > > > > 6 files changed, 28 deletions(-) > > > > > > > > > > [...] > > > > > > > diff --git a/arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts b/arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts > > > > index b343153948f4..7e006d0fbf27 100644 > > > > --- a/arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts > > > > +++ b/arch/arm/boot/dts/sun8i-a33-sinlinx-sina33.dts > > > > @@ -151,13 +151,6 @@ > > > > status = "okay"; > > > > }; > > > > > > > > -&mmc2_8bit_pins { > > > > - /* Increase drive strength for DDR modes */ > > > > - drive-strength = <40>; > > > > > > This is not the default. Maybe we should make it the default? > > > > IIRC, you looked into the emmc standard some time ago, and you > > concluded that the default was 30mA. > > > > I don't really want to make it the default if only a couple of boards > > need it though. I've droped that part from the patch. > > IIRC you have both boards that have it? Could you test dropping > the drive strength down to 30 mA? I think I still do, I'll try to find the time to test this. Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: