From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95439C04EB9 for ; Thu, 29 Nov 2018 22:42:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BFB620989 for ; Thu, 29 Nov 2018 22:42:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gYhCcQJb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="PtfqTHsx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BFB620989 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Kn1D2BTocRhJSRgJ1mwrORWfVIUk3merFaiK4GhcVTg=; b=gYhCcQJb+xUuBS +AdtHc+q8VFzYOjJdk9JNjgK3QnEe6Qo9kCqD4Krbfi1hjVmybk9UL+5KzTLC9ZcBCwRp4j7TEUlk WefEGGGILaRn4dXPq8q2Exp4VeUoBkbs58DRgr9V8o9P4/auOoZxOitYcL/G6+h0QBE0c7jlhFrqU wlPZ0i4nr4PLGLKr/8zBU7EFkiM1kMVd1X89daQl7HG7G/21OeXqCMdahJnq9WiNcV+wFTJW1Yha0 wnu9uhi5ikw5AfoS3XbPFPmkNJ4yiidDyeWm2UCiOarI7G9PgJtAftRjPW28avOThBaDev853pYAA bsE2Eh0yBk41g7Sv8+WQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gSV1H-0006Hn-2A; Thu, 29 Nov 2018 22:42:51 +0000 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gSV1E-0006FE-42 for linux-arm-kernel@lists.infradead.org; Thu, 29 Nov 2018 22:42:49 +0000 Received: by mail-oi1-x243.google.com with SMTP id x23so3130883oix.3 for ; Thu, 29 Nov 2018 14:42:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=AjC9mgriRN0LP5/i352ByFedKXXyljq0Tw1jexu8YxI=; b=PtfqTHsxl6T1aNf0xojBdLJL2v9MbOIxqkmi4EBvOIsB6/VNvqeZXyexp3+NuL/5VZ UphWUEJCTG5j+lozKPie/tnYgMcaqEL39/ZVqJ8TSBMcpOYnFnwOtn560U04O15uWFwP 0oolYz+G70vSSLEB9DHVm6eGFlnmvBGrXN/cQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=AjC9mgriRN0LP5/i352ByFedKXXyljq0Tw1jexu8YxI=; b=QQCPO7s+nYxfobLuYGd/k48yKo/QvftU+FLRmw0obWC6pRAJIlkL2tEJyMgK65s63S y7cl9WBCwtA4oKt/2Vi6fP+da2t7aCKS0ZeN02O8/zgloGHAXk+WtMuHP7SgFSqDhq3V a8rEHJunyxKJhtKMbgxwBVvPwdzOlkLK5GHpsh8EenDj5PDP1zmH/hhRe6n+sQBlMUMN 47kZ9aAGM0Pec6GHxc/z1VEZmJQ+BbRMewQGcvdVFCRIrnBiXdIwo6F92ienpclq+Ol7 BHs6gkSGZAMDbaAkhJcdt0kEQJTpactVYQEHIjeubpkyAyjKd3EW207klNPz4bfJ+RpZ K5pw== X-Gm-Message-State: AA+aEWbX8gzRkiAk7aHrZx4yvyCn2w+xcI+i1eHE6idRzdoyYM06qy2t VQnYAD6tDmOEeBmuSQ3La5ukCQ== X-Google-Smtp-Source: AFSGD/V/06Xq6gnWR7jgDlscc4uygAlxATa8cSpa9hZ+lbm/T3kTLecXbfMv00/Cc9Fm634nupYJWA== X-Received: by 2002:aca:e495:: with SMTP id b143mr1864251oih.286.1543531356404; Thu, 29 Nov 2018 14:42:36 -0800 (PST) Received: from localhost ([2600:1700:141:4960:d408:b2c2:72bf:467a]) by smtp.gmail.com with ESMTPSA id y17sm2507709oie.41.2018.11.29.14.42.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Nov 2018 14:42:35 -0800 (PST) Date: Thu, 29 Nov 2018 16:42:34 -0600 From: Andy Gross To: Stephen Boyd Subject: Re: [PATCH] drm: msm: Check cmd_db_read_aux_data() for failure Message-ID: <20181129224234.GD32306@hector.attlocal.net> References: <20181129163826.178670-1-swboyd@chromium.org> <20181129223600.GC32306@hector.attlocal.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181129223600.GC32306@hector.attlocal.net> User-Agent: Mutt/1.5.23.1 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181129_144248_159449_FACA61AA X-CRM114-Status: GOOD ( 12.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stephen Rothwell , kbuild test robot , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Evan Green , Bjorn Andersson , Jordan Crouse , Rob Clark , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 29, 2018 at 04:36:00PM -0600, Andy Gross wrote: > On Thu, Nov 29, 2018 at 08:38:26AM -0800, Stephen Boyd wrote: > > We need to check the call to cmd_db_read_aux_data() for the error case, > > so that we don't continue and use potentially uninitialized values for > > 'pri_count' and 'sec_count'. Otherwise, we get the following compiler > > warnings: > > > > drivers/gpu/drm/msm/adreno/a6xx_gmu.c: In function 'a6xx_gmu_rpmh_arc_votes_init.isra.12': > > drivers/gpu/drm/msm/adreno/a6xx_gmu.c:943:12: warning: 'pri_count' is used uninitialized in this function [-Wuninitialized] > > pri_count >>= 1; > > ^~~ > > drivers/gpu/drm/msm/adreno/a6xx_gmu.c:948:12: warning: 'sec_count' may be used uninitialized in this function > > [-Wmaybe-uninitialized] > > sec_count >>= 1; > > ^~~ > > > > Reported-by: Stephen Rothwell > > Reported-by: kbuild test robot > > Cc: Jordan Crouse > > Cc: Bjorn Andersson > > Cc: Evan Green > > Cc: Jordan Crouse > > Cc: Rob Clark > > Fixes: ed3cafa79ea7 ("soc: qcom: cmd-db: Stop memcpy()ing in cmd_db_read_aux_data()") > > Signed-off-by: Stephen Boyd On second thought, this needs to go through drm tree. Reviewed-by: Andy Gross _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel