From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>,
"broonie@kernel.org" <broonie@kernel.org>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"robh@kernel.org" <robh@kernel.org>,
"vigneshr@ti.com" <vigneshr@ti.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"marek.vasut@gmail.com" <marek.vasut@gmail.com>,
"frieder.schrempf@exceet.de" <frieder.schrempf@exceet.de>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"computersforpeace@gmail.com" <computersforpeace@gmail.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 1/7] spi: add support for octo mode I/O data transfer
Date: Mon, 3 Dec 2018 09:04:44 +0100 [thread overview]
Message-ID: <20181203090444.0c37efa7@bbrezillon> (raw)
In-Reply-To: <1542863544-21257-2-git-send-email-yogeshnarayan.gaur@nxp.com>
Hi Yogesh,
On Thu, 22 Nov 2018 05:14:31 +0000
Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> wrote:
> Add flags for Octo mode I/O data transfer
> Required for the SPI controller which can do the data transfer (TX/RX)
> on 8 data lines e.g. NXP FlexSPI controller.
> SPI_TX_OCTO: transmit with 8 wires
> SPI_RX_OCTO: receive with 8 wires
>
> Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com>
> Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
> Changes for v4:
> - Rebase on top of v4.20-rc2
> Changes for v3:
> - Modified string 'octal' with 'octo'.
When I listed the differences between your version and mine, I
mentioned the OCTO vs OCTAL name, but I didn't say my decision was the
correct one :-). Looks like OCTAL is the term employed almost
everywhere, and it's also consistent with DUAL. Would you mind
sending a new version reverting the name to OCTAL.
Sorry for the unclear statement in my previous review.
Regards,
Boris
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-03 8:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 5:14 [PATCH v4 0/7] spi: add support for octo mode Yogesh Narayan Gaur
2018-11-22 5:14 ` [PATCH v4 1/7] spi: add support for octo mode I/O data transfer Yogesh Narayan Gaur
2018-12-03 8:04 ` Boris Brezillon [this message]
2018-12-03 8:47 ` Yogesh Narayan Gaur
2018-11-22 5:14 ` [PATCH v4 2/7] spi: spi-mem: " Yogesh Narayan Gaur
2018-11-22 5:14 ` [PATCH v4 3/7] mtd: spi-nor: add opcodes for octo Read/Write commands Yogesh Narayan Gaur
2018-11-22 5:14 ` [PATCH v4 4/7] mtd: spi-nor: add octo read flag for flash mt35xu512aba Yogesh Narayan Gaur
2018-11-22 5:14 ` [PATCH v4 5/7] mtd: m25p80: add support of octo mode I/O transfer Yogesh Narayan Gaur
2018-11-22 5:15 ` [PATCH v4 6/7] spi: nxp-fspi: add octo mode flag bit for octal support Yogesh Narayan Gaur
2018-11-22 5:15 ` [PATCH v4 7/7] arm64: dts: lx2160a: update fspi node Yogesh Narayan Gaur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203090444.0c37efa7@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=broonie@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frieder.schrempf@exceet.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=vigneshr@ti.com \
--cc=yogeshnarayan.gaur@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).