From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24860C04EB9 for ; Mon, 3 Dec 2018 08:05:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4B4C2081C for ; Mon, 3 Dec 2018 08:05:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ag7jpwd4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4B4C2081C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aNK/gV69/jojfy4WMxu68FR46Ql15hKA8SrGylCz1mc=; b=ag7jpwd4966IDI 9diUW7GS9LWIFrtxfeRO7WxGDzW2cdLGiSWk8kcTBj31SnzmioMPkoEBxeBBJu3SIelLZ7M6WWyOs JpqoMjuvXjbIXnfcutNtFNSqhQsnwVrFkMMVqUZNgaHq+TPpbEvdyBvUwdJkgmRdrz1I3eVAlc0e7 26MX2rL9KS19zS7ONM0T2GQg5Hv9K0qtVRs13D70JZyYI8wQ10BlaYoRhUfiDOPCfCUV840SHVB6t MSurMlqOxCGGGyM//Oo068tWhw7gsPufyLGmJL+n7c88TbJp25C+VLApQX0Qr1EpUWypZCRFIp6qv cws+KJQa+PIheCtpcIbQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gTjE5-0007w8-Sv; Mon, 03 Dec 2018 08:05:09 +0000 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gTjE2-0006hP-C2; Mon, 03 Dec 2018 08:05:07 +0000 Received: by mail.bootlin.com (Postfix, from userid 110) id F37B520787; Mon, 3 Dec 2018 09:04:54 +0100 (CET) Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) by mail.bootlin.com (Postfix) with ESMTPSA id 9C15220CFA; Mon, 3 Dec 2018 09:04:44 +0100 (CET) Date: Mon, 3 Dec 2018 09:04:44 +0100 From: Boris Brezillon To: Yogesh Narayan Gaur , "broonie@kernel.org" Subject: Re: [PATCH v4 1/7] spi: add support for octo mode I/O data transfer Message-ID: <20181203090444.0c37efa7@bbrezillon> In-Reply-To: <1542863544-21257-2-git-send-email-yogeshnarayan.gaur@nxp.com> References: <1542863544-21257-1-git-send-email-yogeshnarayan.gaur@nxp.com> <1542863544-21257-2-git-send-email-yogeshnarayan.gaur@nxp.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181203_000506_559831_826F85DC X-CRM114-Status: UNSURE ( 9.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "robh@kernel.org" , "vigneshr@ti.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-spi@vger.kernel.org" , "marek.vasut@gmail.com" , "frieder.schrempf@exceet.de" , "linux-mtd@lists.infradead.org" , "computersforpeace@gmail.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Yogesh, On Thu, 22 Nov 2018 05:14:31 +0000 Yogesh Narayan Gaur wrote: > Add flags for Octo mode I/O data transfer > Required for the SPI controller which can do the data transfer (TX/RX) > on 8 data lines e.g. NXP FlexSPI controller. > SPI_TX_OCTO: transmit with 8 wires > SPI_RX_OCTO: receive with 8 wires > > Signed-off-by: Yogesh Gaur > Reviewed-by: Boris Brezillon > --- > Changes for v4: > - Rebase on top of v4.20-rc2 > Changes for v3: > - Modified string 'octal' with 'octo'. When I listed the differences between your version and mine, I mentioned the OCTO vs OCTAL name, but I didn't say my decision was the correct one :-). Looks like OCTAL is the term employed almost everywhere, and it's also consistent with DUAL. Would you mind sending a new version reverting the name to OCTAL. Sorry for the unclear statement in my previous review. Regards, Boris _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel