From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Phil Edworthy <phil.edworthy@renesas.com>
Cc: "Stephen Boyd" <sboyd@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Russell King" <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v9 1/2] clk: Add comment about __of_clk_get_by_name() error values
Date: Mon, 3 Dec 2018 15:30:40 +0200 [thread overview]
Message-ID: <20181203133040.GN10650@smile.fi.intel.com> (raw)
In-Reply-To: <20181203111309.3709-2-phil.edworthy@renesas.com>
On Mon, Dec 03, 2018 at 11:13:08AM +0000, Phil Edworthy wrote:
> It's not immediately obvious from the code that failure to get a
> clock provider can return either -ENOENT or -EINVAL. Therefore, add
> a comment to highlight this.
> +/*
> + * Beware the return values when np is valid, but no clock provider is found.
> + * If name = NULL, the function returns -ENOENT.
> + * If name != NULL, the function returns -EINVAL. This is because __of_clk_get()
I would start new sentence from new line
(this will emphasize the possible variants)
* This is ...
Otherwise looks good to me:
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> + * is called even if of_property_match_string() returns an error.
> + */
> static struct clk *__of_clk_get_by_name(struct device_node *np,
> const char *dev_id,
> const char *name)
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-03 13:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 11:13 [PATCH v9 0/2] clk: Add functions to get optional clocks Phil Edworthy
2018-12-03 11:13 ` [PATCH v9 1/2] clk: Add comment about __of_clk_get_by_name() error values Phil Edworthy
2018-12-03 13:30 ` Andy Shevchenko [this message]
2018-12-06 12:30 ` Phil Edworthy
2019-01-16 15:18 ` Phil Edworthy
2019-01-24 19:35 ` Stephen Boyd
2019-01-24 21:07 ` Andy Shevchenko
2019-02-06 18:34 ` Stephen Boyd
2018-12-03 11:13 ` [PATCH v9 2/2] clk: Add (devm_)clk_get_optional() functions Phil Edworthy
2019-02-06 18:34 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203133040.GN10650@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=geert@linux-m68k.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mturquette@baylibre.com \
--cc=phil.edworthy@renesas.com \
--cc=sboyd@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox