From: Will Deacon <will.deacon@arm.com>
To: Andrew Murray <andrew.murray@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Julien Thierry <julien.thierry@arm.com>,
Christoffer Dall <christoffer.dall@arm.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/4] arm64: KVM: add accessors to track guest/host only counters
Date: Mon, 3 Dec 2018 14:31:14 +0000 [thread overview]
Message-ID: <20181203143114.GA26831@arm.com> (raw)
In-Reply-To: <1542885950-23816-3-git-send-email-andrew.murray@arm.com>
On Thu, Nov 22, 2018 at 11:25:48AM +0000, Andrew Murray wrote:
> In order to effeciently enable/disable guest/host only perf counters
> at guest entry/exit we add bitfields to kvm_cpu_context for guest and
> host only events as well as accessors for updating them.
>
> Signed-off-by: Andrew Murray <andrew.murray@arm.com>
> ---
> arch/arm64/include/asm/kvm_host.h | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
> index 1550192..4a828eb 100644
> --- a/arch/arm64/include/asm/kvm_host.h
> +++ b/arch/arm64/include/asm/kvm_host.h
> @@ -203,6 +203,8 @@ struct kvm_cpu_context {
> };
>
> struct kvm_vcpu *__hyp_running_vcpu;
> + u32 events_host_only;
> + u32 events_guest_only;
> };
>
> typedef struct kvm_cpu_context kvm_cpu_context_t;
> @@ -472,6 +474,24 @@ static inline int kvm_arch_vcpu_run_pid_change(struct kvm_vcpu *vcpu)
> {
> return kvm_arch_vcpu_run_map_fp(vcpu);
> }
> +static inline void kvm_clr_set_host_pmu_events(u32 clr, u32 set)
> +{
> + kvm_cpu_context_t *ctx = this_cpu_ptr(&kvm_host_cpu_state);
> +
> + ctx->events_host_only &= ~clr;
> + ctx->events_host_only |= set;
> +}
Do you actually need this clr/set function, or can you just use the
facilities provided by bitfield.h at the callsites?
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-03 14:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 11:25 [PATCH v3 0/4] arm64: Support perf event modifiers :G and :H Andrew Murray
2018-11-22 11:25 ` [PATCH v3 1/4] arm64: arm_pmu: remove unnecessary isb instruction Andrew Murray
2018-11-22 11:25 ` [PATCH v3 2/4] arm64: KVM: add accessors to track guest/host only counters Andrew Murray
2018-12-03 14:31 ` Will Deacon [this message]
2018-12-03 15:05 ` Andrew Murray
2018-12-03 16:58 ` Will Deacon
2018-12-03 22:44 ` Andrew Murray
2018-11-22 11:25 ` [PATCH v3 3/4] arm64: arm_pmu: Add support for exclude_host/exclude_guest attributes Andrew Murray
2018-12-03 15:04 ` Will Deacon
2018-12-03 22:37 ` Andrew Murray
2018-11-22 11:25 ` [PATCH v3 4/4] arm64: KVM: Enable support for :G/:H perf event modifiers Andrew Murray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203143114.GA26831@arm.com \
--to=will.deacon@arm.com \
--cc=andrew.murray@arm.com \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@arm.com \
--cc=julien.thierry@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).