From: Shawn Guo <shawnguo@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Gary Bisson <gary.bisson@boundarydevices.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Troy Kisky <troy.kisky@boundarydevices.com>
Subject: Re: [PATCH] ARM: dts: imx7d-nitrogen7: Fix the description of the Wifi clock
Date: Wed, 5 Dec 2018 12:10:15 +0800 [thread overview]
Message-ID: <20181205041014.GL3987@dragon> (raw)
In-Reply-To: <CAOMZO5DEboD6myFuMUCRgFLsgdFAz+9SwK874SsqbmwcQnQaFg@mail.gmail.com>
On Sun, Dec 02, 2018 at 06:42:08PM -0200, Fabio Estevam wrote:
> Hi Gary,
>
> On Sun, Dec 2, 2018 at 5:09 PM Gary Bisson
> <gary.bisson@boundarydevices.com> wrote:
>
> > Actually the whole regulator should be changed into a pwrseq as it is
> > really a WL_EN signal.
>
> Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.txt only lists
> a 'reset-gpios' entry, so it seems this should stays as regulator.
>
> > > +
> > > + usdhc2_pwrseq: usdhc2_pwrseq {
> > > + compatible = "mmc-pwrseq-simple";
> > > + clocks = <&clks IMX7D_CLKO2_ROOT_DIV>;
> > > + clock-names = "slow";
> >
> > Shouldn't the name be "ext_clock"?
>
> Yes, you are correct.
>
> If you agree that we should keep the regulator as is, then I can send a v2.
Okay, dropped RFC patch and waiting for new version.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2018-12-05 4:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 1:47 [PATCH] ARM: dts: imx7d-nitrogen7: Fix the description of the Wifi clock Fabio Estevam
2018-12-02 19:09 ` Gary Bisson
2018-12-02 20:42 ` Fabio Estevam
2018-12-05 4:10 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205041014.GL3987@dragon \
--to=shawnguo@kernel.org \
--cc=festevam@gmail.com \
--cc=gary.bisson@boundarydevices.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).