From: Eduardo Valentin <edubezval@gmail.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Zhang Rui <rui.zhang@intel.com>,
linux-pm@vger.kernel.org, Mikulas Patocka <mpatocka@redhat.com>,
linux-arm-kernel@lists.infradead.org,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH] thermal: armada: fix broken temperature sensor in 4.19
Date: Tue, 4 Dec 2018 21:38:43 -0800 [thread overview]
Message-ID: <20181205053842.GB29413@localhost.localdomain> (raw)
In-Reply-To: <20181125005453.GV30658@n2100.armlinux.org.uk>
On Sun, Nov 25, 2018 at 12:54:53AM +0000, Russell King - ARM Linux wrote:
> On Sat, Nov 24, 2018 at 06:45:00PM -0500, Mikulas Patocka wrote:
> > The patch 8c0e64ac4075b7ca870098ed2ad6089868f5fa7b ("thermal: armada: get
> > rid of the ->is_valid() pointer") breaks temperature readings on the
> > MacchiatoBIN board. Reading the temperature with
> > cat /sys/devices/virtual/thermal/thermal_zone*/temp
> > results in errors:
> >
> > armada_thermal f06f808c.thermal: Temperature sensor reading not valid
> > armada_thermal f2400078.thermal: Temperature sensor reading not valid
> > armada_thermal f4400078.thermal: Temperature sensor reading not valid
> >
> > The patch was meant as simple refactoring, but unfortunatelly, it reverses
> > the condition in armada_get_temp_legacy, so that the error is reported if
> > armada_is_valid returns true.
>
> I sent a patch for exactly this issue on 9th November... it doesn't
> seem to have made it into mainline yet.
I applied Russell's patch.
>
> >
> > Fixes: 8c0e64ac4075 ("thermal: armada: get rid of the ->is_valid() pointer")
> > Cc: stable@vger.kernel.org # 4.19
> >
> > ---
> > drivers/thermal/armada_thermal.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Index: linux-4.19.4/drivers/thermal/armada_thermal.c
> > ===================================================================
> > --- linux-4.19.4.orig/drivers/thermal/armada_thermal.c 2018-11-25 00:19:20.000000000 +0100
> > +++ linux-4.19.4/drivers/thermal/armada_thermal.c 2018-11-25 00:39:49.000000000 +0100
> > @@ -357,7 +357,7 @@ static int armada_get_temp_legacy(struct
> > int ret;
> >
> > /* Valid check */
> > - if (armada_is_valid(priv)) {
> > + if (!armada_is_valid(priv)) {
> > dev_err(priv->dev,
> > "Temperature sensor reading not valid\n");
> > return -EIO;
>
> --
> RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
> FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
> According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2018-12-05 5:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-24 23:45 [PATCH] thermal: armada: fix broken temperature sensor in 4.19 Mikulas Patocka
2018-11-24 23:53 ` Mikulas Patocka
2018-11-25 0:54 ` Russell King - ARM Linux
2018-12-05 5:38 ` Eduardo Valentin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205053842.GB29413@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=miquel.raynal@bootlin.com \
--cc=mpatocka@redhat.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox