From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BF0AC04EB9 for ; Wed, 5 Dec 2018 09:38:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6993520879 for ; Wed, 5 Dec 2018 09:38:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kfDX1yA0"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="GJHzoGw3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6993520879 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rHmYkMTqqbyw0FbWmA70NZdL3iyuJagdbIfCWmwJHN0=; b=kfDX1yA0yNOLPd lhTW1YlJPoymeZH9V/BmrUDlPr0UrO5HdeqJilm4sjE0pHFXmxo7CIn9b7L5qvYA9u7hwdgjVKKEM FQ+rmZC7/EqikuBKdoQnM1ZOS02s1rX037zz3cD8AR7SbEXRL2olz/dW6pKrAEflraD5E09kESK85 I9VB6rJGk6rQaIZA26a6iX1gqhDfN+FEJ8y+VZ3V61Ep3RNaQxhgOlIguXC3Db/vdCUUvnodCepOw 6bwmph7RTeU2DCkL+54yfFttSvR9DalNA7mr1+Z816DFes9h8XtDkS8M87GrFpR81YXLKFvrxDqPq MTv5rMroa7/R+EFw4o6g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUTd8-0007AF-Bm; Wed, 05 Dec 2018 09:38:06 +0000 Received: from hqemgate15.nvidia.com ([216.228.121.64]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUTd5-00076z-CF for linux-arm-kernel@lists.infradead.org; Wed, 05 Dec 2018 09:38:04 +0000 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 05 Dec 2018 01:37:48 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 05 Dec 2018 01:37:52 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 05 Dec 2018 01:37:52 -0800 Received: from tbergstrom-lnx.Nvidia.com (172.20.13.39) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 5 Dec 2018 09:37:52 +0000 Received: by tbergstrom-lnx.Nvidia.com (Postfix, from userid 1000) id 1688340480; Wed, 5 Dec 2018 11:37:50 +0200 (EET) Date: Wed, 5 Dec 2018 11:37:50 +0200 From: Peter De Schrijver To: Joseph Lo Subject: Re: [PATCH 03/19] dt-bindings: cpufreq: tegra124: remove vdd-cpu-supply from required properties Message-ID: <20181205093750.GG26056@pdeschrijver-desktop.Nvidia.com> References: <20181204092548.3038-1-josephl@nvidia.com> <20181204092548.3038-4-josephl@nvidia.com> <20181204153600.GA26056@pdeschrijver-desktop.Nvidia.com> <3a6f4512-db3f-4cba-21da-572edf14c5dc@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3a6f4512-db3f-4cba-21da-572edf14c5dc@nvidia.com> X-NVConfidentiality: public User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL106.nvidia.com (172.18.146.12) To HQMAIL101.nvidia.com (172.20.187.10) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1544002668; bh=Il2j97GP3dTrMPtpfoCn0yEUDZygBJc6NhAj+x5cAZg=; h=X-PGP-Universal:Date:From:To:CC:Subject:Message-ID:References: MIME-Version:Content-Type:Content-Disposition:In-Reply-To: X-NVConfidentiality:User-Agent:X-Originating-IP:X-ClientProxiedBy; b=GJHzoGw3krtSRkocDc0M1Pw2J6AsPRAswYmePaWZQXpQNyJIEaV0CFSEpHWqCi9RA kUnyQvBi4t0X+mIE0mZZTW7gtDx7tRwUFudBmyuiPn9Vg1pPXJyvQgpBurvKd5CetG wr6wB8nkEMq1/YLchl6CeGRgS+98RytuNBpIg9E4P+QVUbRnjXCMRik9DUzesJe0NZ Q15DISCnUvJbWjN+vBioybT8+mGMpWXMQkE/JLo5Igv9twqhFKZTONCNhAbh8MBrdF f9EGvD3W49YSk2mPnODRGkeMzeqvULW9w52RspS3DNPB0k+j0fUbbsUu2V4oLjqfVN xGF3JhiX6ztWQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181205_013803_424003_8FACAE00 X-CRM114-Status: GOOD ( 18.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jonathan Hunter , Thierry Reding , linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 05, 2018 at 11:05:58AM +0800, Joseph Lo wrote: > On 12/4/18 11:36 PM, Peter De Schrijver wrote: > > On Tue, Dec 04, 2018 at 05:25:32PM +0800, Joseph Lo wrote: > > > The Tegra124 cpufreq driver works only with DFLL clock, which is a > > > hardware-based frequency/voltage controller. The driver doesn't need to > > > control the regulator itself. Hence remove that. > > > > > > > I think this is required for DFLL controlled I2C regulators because the > > regulator is queried for voltage selectors and I2C slave ID? > > > > Hi Peter, > > Yes, it's required for DFLL-I2C mode and defined in DFLL node. It's not > needed here in the CPU node for CPU freq driver to handle that. Hence remove > that. > Ah right. So yes, this is fine then. Peter. > Thanks, > Joseph > > > > > > > Cc: devicetree@vger.kernel.org > > > Signed-off-by: Joseph Lo > > > --- > > > .../devicetree/bindings/cpufreq/nvidia,tegra124-cpufreq.txt | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/cpufreq/nvidia,tegra124-cpufreq.txt b/Documentation/devicetree/bindings/cpufreq/nvidia,tegra124-cpufreq.txt > > > index b1669fbfb740..031545a29caf 100644 > > > --- a/Documentation/devicetree/bindings/cpufreq/nvidia,tegra124-cpufreq.txt > > > +++ b/Documentation/devicetree/bindings/cpufreq/nvidia,tegra124-cpufreq.txt > > > @@ -13,7 +13,6 @@ Required properties: > > > - pll_x: Fast PLL clocksource. > > > - pll_p: Auxiliary PLL used during fast PLL rate changes. > > > - dfll: Fast DFLL clocksource that also automatically scales CPU voltage. > > > -- vdd-cpu-supply: Regulator for CPU voltage > > > Optional properties: > > > - clock-latency: Specify the possible maximum transition latency for clock, > > > @@ -37,7 +36,6 @@ cpus { > > > <&dfll>; > > > clock-names = "cpu_g", "cpu_lp", "pll_x", "pll_p", "dfll"; > > > clock-latency = <300000>; > > > - vdd-cpu-supply: <&vdd_cpu>; > > > }; > > > <...> > > > -- > > > 2.19.2 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel