From: Vinod Koul <vkoul@kernel.org>
To: Frank Lee <tiny.windzz@gmail.com>
Cc: linux-soc@vger.kernel.org, dmaengine@vger.kernel.org,
linux-arm-msm@vger.kernel.org, okaya@kernel.org,
sudeep.dutt@intel.com, Haojian Zhuang <haojian.zhuang@gmail.com>,
linux-kernel@vger.kernel.org, ashutosh.dixit@intel.com,
David Brown <david.brown@linaro.org>,
linux-arm-kernel@lists.infradead.org,
Andy Gross <andy.gross@linaro.org>,
dan.j.williams@intel.com, robert.jarzmik@free.fr,
daniel@zonque.org
Subject: Re: [PATCH] dmaengine: remove DBGFS_FUNC_DECL()
Date: Wed, 5 Dec 2018 21:29:12 +0530 [thread overview]
Message-ID: <20181205155912.GP2847@vkoul-mobl> (raw)
In-Reply-To: <CAEExFWu1ahDPqKbYWKPY_bQuw=1Kp1gUki+CpQ7Mq5sNNiy_tg@mail.gmail.com>
On 05-12-18, 23:49, Frank Lee wrote:
> On Wed, Dec 5, 2018 at 4:27 PM Vinod Koul <vkoul@kernel.org> wrote:
> >
> > On 30-11-18, 10:42, Yangtao Li wrote:
> > > We already have the DEFINE_SHOW_ATTRIBUTE,There is no need to define
> > > such a macro,so remove DBGFS_FUNC_DECL.Also use macro to simplify some
> > > code.
> >
> > Spaces after full stop and comma please
> >
> > >
> > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > > ---
> > > drivers/dma/amba-pl08x.c | 14 ++------------
> > > drivers/dma/mic_x100_dma.c | 22 +++-------------------
> > > drivers/dma/pxa_dma.c | 24 ++++++++++++------------
> > > drivers/dma/qcom/hidma_dbg.c | 33 ++++++---------------------------
> >
> > Do you mind splitting it per file.
> Hi Vinod:
>
> Why not apply it once ？The change is not too big.
It is not about big or small. A patch should do one thing and touch a
single module.
It also helps people when they look at changes and backports.
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-05 15:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 15:42 [PATCH] dmaengine: remove DBGFS_FUNC_DECL() Yangtao Li
2018-11-30 15:59 ` Sinan Kaya
2018-11-30 19:18 ` Robert Jarzmik
2018-12-05 8:27 ` Vinod Koul
2018-12-05 15:49 ` Frank Lee
2018-12-05 15:59 ` Vinod Koul [this message]
2018-12-05 16:21 ` Frank Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181205155912.GP2847@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=andy.gross@linaro.org \
--cc=ashutosh.dixit@intel.com \
--cc=dan.j.williams@intel.com \
--cc=daniel@zonque.org \
--cc=david.brown@linaro.org \
--cc=dmaengine@vger.kernel.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=okaya@kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=sudeep.dutt@intel.com \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).