linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: Fix hsi gdd range for omap4
@ 2018-12-05 23:05 Tony Lindgren
  2018-12-06  0:20 ` Sebastian Reichel
  0 siblings, 1 reply; 2+ messages in thread
From: Tony Lindgren @ 2018-12-05 23:05 UTC (permalink / raw)
  To: linux-omap
  Cc: devicetree, Benoît Cousson, linux-arm-kernel,
	Sebastian Reichel

While reviewing the missing mcasp ranges I noticed omap4 hsi range
for gdd is wrong so let's fix it.

I'm not aware of any omap4 devices in mainline kernel though that use
hsi though.

Cc: Sebastian Reichel <sre@kernel.org>
Fixes: 84badc5ec5fc ("ARM: dts: omap4: Move l4 child devices to probe
them with ti-sysc")
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/boot/dts/omap4-l4.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/omap4-l4.dtsi b/arch/arm/boot/dts/omap4-l4.dtsi
--- a/arch/arm/boot/dts/omap4-l4.dtsi
+++ b/arch/arm/boot/dts/omap4-l4.dtsi
@@ -196,12 +196,12 @@
 			clock-names = "fck";
 			#address-cells = <1>;
 			#size-cells = <1>;
-			ranges = <0x0 0x58000 0x4000>;
+			ranges = <0x0 0x58000 0x5000>;
 
 			hsi: hsi@0 {
 				compatible = "ti,omap4-hsi";
 				reg = <0x0 0x4000>,
-				      <0x4a05c000 0x1000>;
+				      <0x5000 0x1000>;
 				reg-names = "sys", "gdd";
 
 				clocks = <&l3_init_clkctrl OMAP4_HSI_CLKCTRL 0>;
-- 
2.19.2

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: Fix hsi gdd range for omap4
  2018-12-05 23:05 [PATCH] ARM: dts: Fix hsi gdd range for omap4 Tony Lindgren
@ 2018-12-06  0:20 ` Sebastian Reichel
  0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2018-12-06  0:20 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: devicetree, linux-omap, Benoît Cousson, linux-arm-kernel


[-- Attachment #1.1: Type: text/plain, Size: 1481 bytes --]

Hi,

On Wed, Dec 05, 2018 at 03:05:53PM -0800, Tony Lindgren wrote:
> While reviewing the missing mcasp ranges I noticed omap4 hsi range
> for gdd is wrong so let's fix it.
> 
> I'm not aware of any omap4 devices in mainline kernel though that use
> hsi though.

While OMAP4 HSI seems to be very similar to OMAP3 SSI, it's not
supported by the omap-ssi driver. I don't know what changes are
required and I don't know any hardware using omap4-hsi.

FWIW the change is

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

> Cc: Sebastian Reichel <sre@kernel.org>
> Fixes: 84badc5ec5fc ("ARM: dts: omap4: Move l4 child devices to probe
> them with ti-sysc")
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
>  arch/arm/boot/dts/omap4-l4.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/omap4-l4.dtsi b/arch/arm/boot/dts/omap4-l4.dtsi
> --- a/arch/arm/boot/dts/omap4-l4.dtsi
> +++ b/arch/arm/boot/dts/omap4-l4.dtsi
> @@ -196,12 +196,12 @@
>  			clock-names = "fck";
>  			#address-cells = <1>;
>  			#size-cells = <1>;
> -			ranges = <0x0 0x58000 0x4000>;
> +			ranges = <0x0 0x58000 0x5000>;
>  
>  			hsi: hsi@0 {
>  				compatible = "ti,omap4-hsi";
>  				reg = <0x0 0x4000>,
> -				      <0x4a05c000 0x1000>;
> +				      <0x5000 0x1000>;
>  				reg-names = "sys", "gdd";
>  
>  				clocks = <&l3_init_clkctrl OMAP4_HSI_CLKCTRL 0>;
> -- 
> 2.19.2

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-06  0:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-05 23:05 [PATCH] ARM: dts: Fix hsi gdd range for omap4 Tony Lindgren
2018-12-06  0:20 ` Sebastian Reichel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).