From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91C2FC04EB9 for ; Thu, 6 Dec 2018 03:12:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57E712082D for ; Thu, 6 Dec 2018 03:12:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Od94BT4b"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="GwIvI2Mi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57E712082D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9WT6FR91MOVdPpuR5XwnY7XVtrwoIWJPzeZiZ73C3PY=; b=Od94BT4bD798UW zFxKUO7Sgj+ndOE4daN2L81c6tqlssLfgL4kpKxCwMgDrTZD2JBOQ86oULHageEfQs+QVQaB8ZCPI fPAodHnB5Fpi7Ge/uIUZ9ifcYPHrq+IQ1MsEzwovypk4TnCb2qVI0Fyfy1FhRvUhLQzLwZqxE17BO 7RcPZyQ/eepQ0txhs910Ml+z1CqZ/ckEoAxoFGEvg4+kfUzN+EcpuCYwdOtoIgjWrMTSstfblq9mK fcVmp+bsQdQagJtG3arJ05vWiHHL9VilUb8+kx0WmzrsgpN2GmYlZVFFqp5KiNUqOGob0pkDYvbOw /PoQTmhmczkiZLTdfxsA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUk5i-0003wO-QA; Thu, 06 Dec 2018 03:12:42 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUk5T-0003fw-6h for linux-arm-kernel@lists.infradead.org; Thu, 06 Dec 2018 03:12:31 +0000 Received: from dragon (61-216-91-114.HINET-IP.hinet.net [61.216.91.114]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0267E214C1; Thu, 6 Dec 2018 03:12:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544065936; bh=1srqpr2+CHKDjw2wWz6TUjwQO5gzYyKG5yXmWITb7wU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GwIvI2MinP9zKaIHbzW11hMD8At2xd7zFrjkoUHZfFfyoBHDUjjWcN9B3LVUCkYPa FVnY327B1bjL8okRjvi+gQvxMQDUIYc+hgKlTi8HHLz9wKAoP5xjJNPtbPbN2PABxj A7qNK/oqdNKC2A2WOJLMRUYa5tuyXuF+GKKFbsMU= Date: Thu, 6 Dec 2018 11:11:36 +0800 From: Shawn Guo To: Hans Ole Hatzel Subject: Re: [PATCH 2/4] ARM: dts: imx7d: cl-som-imx7: WiLink8 WLAN support Message-ID: <20181206031134.GC3987@dragon> References: <20181204110741.6943-1-hohatzel@jusst.de> <20181204110741.6943-3-hohatzel@jusst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181204110741.6943-3-hohatzel@jusst.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181205_191227_475351_A1CD9042 X-CRM114-Status: GOOD ( 16.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Julian Scheel , linux-arm-kernel@lists.infradead.org, fabio.estevam@nxp.com, ilya@compulab.co.il, linux-imx@nxp.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 04, 2018 at 12:07:39PM +0100, Hans Ole Hatzel wrote: > Add support for WiLink8 module which is connected via USDHC 2. > > Signed-off-by: Hans Ole Hatzel > Signed-off-by: Julian Scheel > --- > arch/arm/boot/dts/imx7d-cl-som-imx7.dts | 64 +++++++++++++++++++++++++ > 1 file changed, 64 insertions(+) > > diff --git a/arch/arm/boot/dts/imx7d-cl-som-imx7.dts b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts > index 11bd713b540f..e77e0cc7de39 100644 > --- a/arch/arm/boot/dts/imx7d-cl-som-imx7.dts > +++ b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts > @@ -30,6 +30,28 @@ > gpio = <&gpio1 5 GPIO_ACTIVE_HIGH>; > enable-active-high; > }; > + > + rf_pwr_en_reg: regulator-rf-pwr-en { > + compatible = "regulator-fixed"; > + regulator-name = "rf-pwr-en-regulator"; I think "rf-pwr-en" is good enough. > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&pca9555 9 GPIO_ACTIVE_HIGH>; > + startup-delay-us = <70000>; > + enable-active-high; > + regulator-always-on; > + }; > + > + wlan_en_reg: regulator-wlan-en { > + compatible = "regulator-fixed"; > + regulator-name = "wlan-en-regulator"; "wlan-en" > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&pca9555 0 GPIO_ACTIVE_HIGH>; > + /* WLAN card specific delay */ > + startup-delay-us = <70000>; > + enable-active-high; > + }; > }; > > &cpu0 { > @@ -199,6 +221,28 @@ > status = "okay"; > }; > > +&usdhc2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usdhc2>; > + cd-gpios = <>; > + wp-gpios = <>; What do these mean? > + no-1-8-v; > + keep-power-in-suspend; > + enable-sdio-wakeup; The property is deprecated. Use "wakeup-source" instead. > + vmmc-supply = <&wlan_en_reg>; > + non-removable; > + cap-power-off-card; > + status = "okay"; Put 'status' at bottom of property list. > + #address-cells = <1>; > + #size-cells = <0>; Have a newline between properties and child node. > + wlcore: wlcore@0 { > + compatible = "ti,wl1835"; > + reg = <2>; The 'reg' property should match unit-address in node name. Shawn > + interrupt-parent = <&gpio1>; > + interrupts = <15 IRQ_TYPE_LEVEL_HIGH>; > + }; > +}; > + > &usdhc3 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_usdhc3>; > @@ -211,6 +255,15 @@ > }; > > &iomuxc { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_hog>; > + > + pinctrl_hog: hoggrp { > + fsl,pins = < > + MX7D_PAD_GPIO1_IO15__GPIO1_IO15 0x34 /* WLAN IRQ */ > + >; > + }; > + > pinctrl_enet1: enet1grp { > fsl,pins = < > MX7D_PAD_SD2_CD_B__ENET1_MDIO 0x30 > @@ -261,6 +314,17 @@ > >; > }; > > + pinctrl_usdhc2: usdhc2grp { > + fsl,pins = < > + MX7D_PAD_SD2_CMD__SD2_CMD 0x59 > + MX7D_PAD_SD2_CLK__SD2_CLK 0x19 > + MX7D_PAD_SD2_DATA0__SD2_DATA0 0x59 > + MX7D_PAD_SD2_DATA1__SD2_DATA1 0x59 > + MX7D_PAD_SD2_DATA2__SD2_DATA2 0x59 > + MX7D_PAD_SD2_DATA3__SD2_DATA3 0x59 > + >; > + }; > + > pinctrl_usdhc3: usdhc3grp { > fsl,pins = < > MX7D_PAD_SD3_CMD__SD3_CMD 0x59 > -- > 2.19.2 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel