From: Shawn Guo <shawnguo@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
Dong Aisheng <dongas86@gmail.com>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V5 3/6] ARM: imx: add initial support for imx7ulp
Date: Thu, 6 Dec 2018 22:48:40 +0800 [thread overview]
Message-ID: <20181206144838.GD12929@dragon> (raw)
In-Reply-To: <CAOMZO5A1R-aoDg5d9OLApArz51daaKcpfyDYJH9hWPnjKCH5=g@mail.gmail.com>
On Sat, Nov 10, 2018 at 01:51:57PM -0200, Fabio Estevam wrote:
> On Sat, Nov 10, 2018 at 1:14 PM A.s. Dong <aisheng.dong@nxp.com> wrote:
>
> > +static void __init imx7ulp_init_machine(void)
> > +{
> > + imx7ulp_pm_init();
> > +
> > + mxc_set_cpu_type(MXC_CPU_IMX7ULP);
> > + /* FIXME: so far there is still no way to retrieve SoC version */
> > + imx_print_silicon_rev("i.MX7ULP", IMX_CHIP_REVISION_UNKNOWN);
>
> Then maybe just do not call imx_print_silicon_rev() for now?
I'm with Fabio on this. Applied the patch by dropping the call and
FIXME comment above.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-06 14:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 15:12 [PATCH V5 0/6] ARM: imx: add imx7ulp support A.s. Dong
2018-11-10 15:12 ` [PATCH V5 1/6] dt-bindings: fsl: add compatible for imx7ulp evk A.s. Dong
2018-11-10 15:50 ` Fabio Estevam
2018-12-06 14:45 ` Shawn Guo
2018-11-10 15:13 ` [PATCH V5 2/6] dt-bindings: fsl: add imx7ulp pm related components bindings A.s. Dong
2018-11-10 15:50 ` Fabio Estevam
2018-12-06 14:45 ` Shawn Guo
2018-11-10 15:13 ` [PATCH V5 3/6] ARM: imx: add initial support for imx7ulp A.s. Dong
2018-11-10 15:51 ` Fabio Estevam
2018-12-06 14:48 ` Shawn Guo [this message]
2018-11-10 15:13 ` [PATCH V5 4/6] dts: imx: add common imx7ulp dtsi support A.s. Dong
2018-11-10 15:52 ` Fabio Estevam
2018-12-06 14:51 ` Shawn Guo
2018-11-10 15:13 ` [PATCH V5 5/6] dts: fsl: add imx7ulp evk support A.s. Dong
2018-12-06 14:54 ` Shawn Guo
2018-11-10 15:13 ` [PATCH V5 6/6] ARM: imx_v6_v7_defconfig: add imx7ulp support A.s. Dong
2018-12-06 14:55 ` Shawn Guo
2018-12-05 6:41 ` [PATCH V5 0/6] ARM: imx: " Aisheng DONG
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206144838.GD12929@dragon \
--to=shawnguo@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=dongas86@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux@armlinux.org.uk \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).