From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D042C04EB8 for ; Thu, 6 Dec 2018 21:13:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBDBD2081C for ; Thu, 6 Dec 2018 21:13:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WYrvvUzb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="dsxztm+A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBDBD2081C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cNKJp4K7mEz0vpTkdbGYskuuC/0sR22Lnio5rEQrZJs=; b=WYrvvUzbnEQrRv /sVxxhdD40OuZzDREuAtn1zQyzmjVTxVYSFaV8FspMSRZ2WEDD+NuGCnvQd9Fr6PEybRbFyigIfhp vw920D8uaU6u7k6BVY2Ed6WBN6CrIp2TXAh9oiJEFt5yCXlFttWX+1FL59vqy1yn0S5K0Avts8sk+ zZm9KwhAFd51PjSUk14jPHAzakSGI0xQ2fdXWN7+JWVPU6q8HcjOs6eLeX9utb9bibikou35jmrTz 2NRddtb5YgWD55nwDCgB97W8gxP/ak8Kyvf0tohYDckNJr8ydLiHPVRe224/tr8n0IY2rXiRx8yar TbjeSMMp/AhPPMPB+Pyw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gV0xZ-0006et-I8; Thu, 06 Dec 2018 21:13:25 +0000 Received: from mail.skyhub.de ([5.9.137.197]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gV0xW-0006cm-EB; Thu, 06 Dec 2018 21:13:24 +0000 Received: from zn.tnic (p200300EC2BCE8F00A9C379089DD692CF.dip0.t-ipconnect.de [IPv6:2003:ec:2bce:8f00:a9c3:7908:9dd6:92cf]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 3C9A91EC04DF; Thu, 6 Dec 2018 22:13:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1544130786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=kf/Pqa4+4o0O/tTGX0ewSkjvR0cGR6THt99q0WvHb9o=; b=dsxztm+A6X/3odCOjkdYcBaHYJlLoE+T5BtDfbq35fx799Lerj7XjTDBNllOGXOcl7G2DT tFucDl63WE9ZwxzKOEXLEzisRMxiv3qUiz7Dg3irZro9Pac8lmpuyLpWhpSR+PEp+ICIFF ovIHpEt+EbRiG4KifiRAz3hlv6LIQhc= Date: Thu, 6 Dec 2018 22:12:52 +0100 From: Borislav Petkov To: Christophe Leroy Subject: Re: [PATCH v2 2/2] kgdb/treewide: constify struct kgdb_arch arch_kgdb_ops Message-ID: <20181206211252.GJ3986@zn.tnic> References: <030d63848e4b0ef4d76ca24597ab8302a393d692.1544083483.git.christophe.leroy@c-s.fr> <5e130b11680be09537913aae9649c84ede763ec8.1544083483.git.christophe.leroy@c-s.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5e130b11680be09537913aae9649c84ede763ec8.1544083483.git.christophe.leroy@c-s.fr> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181206_131322_636497_C78E9CB6 X-CRM114-Status: GOOD ( 16.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , "Gustavo A. R. Silva" , Benjamin Herrenschmidt , Will Deacon , linux-kernel@vger.kernel.org, Paul Mackerras , sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org, Daniel Thompson , Yoshinori Sato , linux-sh@vger.kernel.org, Michael Ellerman , x86@kernel.org, Russell King , Ingo Molnar , Catalin Marinas , James Hogan , linux-snps-arc@lists.infradead.org, uclinux-h8-devel@lists.sourceforge.jp, linux-mips@vger.kernel.org, nios2-dev@lists.rocketboards.org, Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Michal Simek , Vineet Gupta , Randy Dunlap , Douglas Anderson , Ralf Baechle , Richard Kuo , Paul Burton , Jason Wessel , kgdb-bugreport@lists.sourceforge.net, Ley Foon Tan , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 06, 2018 at 08:07:40PM +0000, Christophe Leroy wrote: > checkpatch.pl reports the following: > > WARNING: struct kgdb_arch should normally be const > #28: FILE: arch/mips/kernel/kgdb.c:397: > +struct kgdb_arch arch_kgdb_ops = { > > This report makes sense, as all other ops struct, this > one should also be const. This patch does the change. > > Cc: Vineet Gupta > Cc: Russell King > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Yoshinori Sato > Cc: Richard Kuo > Cc: Michal Simek > Cc: Ralf Baechle > Cc: Paul Burton > Cc: James Hogan > Cc: Ley Foon Tan > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: Rich Felker > Cc: "David S. Miller" > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: x86@kernel.org > Acked-by: Daniel Thompson > Acked-by: Paul Burton > Signed-off-by: Christophe Leroy > --- > v2: Added CCs to all maintainers/supporters identified by get_maintainer.pl and Acks from Daniel and Paul. > > arch/arc/kernel/kgdb.c | 2 +- > arch/arm/kernel/kgdb.c | 2 +- > arch/arm64/kernel/kgdb.c | 2 +- > arch/h8300/kernel/kgdb.c | 2 +- > arch/hexagon/kernel/kgdb.c | 2 +- > arch/microblaze/kernel/kgdb.c | 2 +- > arch/mips/kernel/kgdb.c | 2 +- > arch/nios2/kernel/kgdb.c | 2 +- > arch/powerpc/kernel/kgdb.c | 2 +- > arch/sh/kernel/kgdb.c | 2 +- > arch/sparc/kernel/kgdb_32.c | 2 +- > arch/sparc/kernel/kgdb_64.c | 2 +- > arch/x86/kernel/kgdb.c | 2 +- > include/linux/kgdb.h | 2 +- > 14 files changed, 14 insertions(+), 14 deletions(-) ... > diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c > index 8e36f249646e..e7effc02f13c 100644 > --- a/arch/x86/kernel/kgdb.c > +++ b/arch/x86/kernel/kgdb.c > @@ -804,7 +804,7 @@ int kgdb_arch_remove_breakpoint(struct kgdb_bkpt *bpt) > (char *)bpt->saved_instr, BREAK_INSTR_SIZE); > } > > -struct kgdb_arch arch_kgdb_ops = { > +const struct kgdb_arch arch_kgdb_ops = { > /* Breakpoint instruction: */ > .gdb_bpt_instr = { 0xcc }, > .flags = KGDB_HW_BREAKPOINT, For the x86 bits: Acked-by: Borislav Petkov -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel