From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CACDC64EB1 for ; Fri, 7 Dec 2018 13:22:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CD24208E7 for ; Fri, 7 Dec 2018 13:22:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gSwYKkIB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CD24208E7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4+kMbJc3EEZXlRxA+iIF1ZU1AoxCwW6KKcENSzl7RgI=; b=gSwYKkIBnJU3tMg1V3R/ejqJe lVVdya/M6CUZjbIZrYKvCUdIoAGBuYMFslsLa4P2lWzvt4x+mbq2HnFrk21cEoiOp0Q4yTr7SUuY6 M6oUSfQjd453PVvhnK8vKgvs6L5IUWUacZpJY4198b4gUu8m3T1TpV3TrKYOPF0GVFWJJoWmQ4pr5 /yq1XwlZiP0/FQUdjJNiuQh1v8D0Kaj3x4TdSJxRGFJKlNY307zr250/OWTUCJZbh43XS7hsPqDY0 UlSBsDZ1+JLsH5T1mj77JJ1Ol982/vDy3rhk4mCqve8ximMDZKZOtl7EMEIBDBu2/md4Dyapf1AN5 jl6K9bTqA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gVG54-0008Km-6d; Fri, 07 Dec 2018 13:22:10 +0000 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gVG4r-0008C5-QQ for linux-arm-kernel@lists.infradead.org; Fri, 07 Dec 2018 13:21:59 +0000 Received: by mail.bootlin.com (Postfix, from userid 110) id 227CD20510; Fri, 7 Dec 2018 14:21:46 +0100 (CET) Received: from localhost (aaubervilliers-681-1-79-44.w90-88.abo.wanadoo.fr [90.88.21.44]) by mail.bootlin.com (Postfix) with ESMTPSA id DDDDA20510; Fri, 7 Dec 2018 14:21:35 +0100 (CET) Date: Fri, 7 Dec 2018 14:21:36 +0100 From: Maxime Ripard To: Jagan Teki Subject: Re: [linux-sunxi] Re: [PATCH v4 08/26] drm/sun4i: sun6i_mipi_dsi: Fix VBP size calculation Message-ID: <20181207132136.oa4nzpczytzxhl2d@flea> References: <20181113111633.20189-1-jagan@amarulasolutions.com> <20181113111633.20189-9-jagan@amarulasolutions.com> <20181115095551.uctdkfmuwlnzhjnn@flea> <20181120155715.andrjp5kg6ugcv72@flea> <20181127102450.b65jzhrdpxn5rxmk@flea> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181207_052158_129749_E2AF8470 X-CRM114-Status: GOOD ( 26.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Jernej Skrabec , David Airlie , Catalin Marinas , Michael Turquette , linux-sunxi@googlegroups.com, Will Deacon , linux-kernel , dri-devel , Vasily Khoruzhick , Stephen Boyd , Chen-Yu Tsai , Rob Herring , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-clk , linux-arm-kernel , Icenowy Zheng Content-Type: multipart/mixed; boundary="===============0634873818822694515==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0634873818822694515== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="q7v7wduxjlqssxwi" Content-Disposition: inline --q7v7wduxjlqssxwi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 27, 2018 at 04:34:35PM +0530, Jagan Teki wrote: > On Tue, Nov 27, 2018 at 3:55 PM Maxime Ripard = wrote: > > > > On Tue, Nov 20, 2018 at 09:55:42PM +0530, Jagan Teki wrote: > > > On Tue, Nov 20, 2018 at 9:27 PM Maxime Ripard wrote: > > > > > > > > On Thu, Nov 15, 2018 at 11:19:53PM +0530, Jagan Teki wrote: > > > > > On Thu, Nov 15, 2018 at 3:26 PM Maxime Ripard wrote: > > > > > > > > > > > > Hi, > > > > > > > > > > > > On Tue, Nov 13, 2018 at 04:46:15PM +0530, Jagan Teki wrote: > > > > > > > The horizontal and vertical back porch calculation in BSP > > > > > > > code is simply following the Linux drm comment diagram, in > > > > > > > include/drm/drm_modes.h which is > > > > > > > > > > > > > > [hv]back porch =3D [hv]total - [hv]sync_end > > > > > > > > > > > > > > BSP code form BPI-M64-bsp is calculating vertical back porch = as > > > > > > > (from linux-sunxi/drivers/video/sunxi/disp2/disp/de/disp_lcd.= c) > > > > > > > > > > > > > > timmings->ver_sync_time=3D panel_info->lcd_vspw; > > > > > > > timmings->ver_back_porch=3D panel_info->lcd_vbp-panel_info->l= cd_vspw; > > > > > > > > > > > > > > vbp =3D panel->lcd_vbp; > > > > > > > vspw =3D panel->lcd_vspw; > > > > > > > dsi_dev[sel]->dsi_basic_size0.bits.vbp =3D vbp-vspw; > > > > > > > dsi_dev[sel]->dsi_basic_size0.bits.vbp =3D panel->lcd_vbp - p= anel->lcd_vspw; > > > > > > > =3D> timmings->ver_back_porch + panel_info->lcd_vspw - panel= _info->lcd_vspw > > > > > > > =3D> timmings->ver_back_porch > > > > > > > =3D> mode->vtotal - mode->end > > > > > > > > > > > > > > Which evatually same as mode->vtotal - mode->vsync_end so upd= ate the > > > > > > > same in SUN6I_DSI_BASIC_SIZE0_VBP > > > > > > > > > > > > > > On the information note, existing SUN6I_DSI_BASIC_SIZE0_VSA i= s proper > > > > > > > value. > > > > > > > > > > > > > > Signed-off-by: Jagan Teki > > > > > > > > > > > > I've tested your changes on my A33 board, and this commit will = break > > > > > > it. > > > > > > > > > > > > It creates vblank timeouts, and visual artifacts at the bottom = of the > > > > > > display. > > > > > > > > > > Strange, VBP is earlier gives front porch which is anyway wrong. > > > > > > > > > > > > > > > > > Later commits seem to fix the issue, but will create some blank= ing on > > > > > > the upper third of the display. > > > > > > > > > > > > Since the documentation is quite sparse, and a MIPI-DSI analyze= r is > > > > > > way too expensive, I'd really like to have at least what each o= f these > > > > > > commits are actually fixing, and what symptoms each of these we= re > > > > > > causing, and not just "the BSP does it". > > > > > > > > > > W/o this 2-lane panel is breaking, same vblank timeout and visual > > > > > artifacts at the bottom of the panel. though the commits may refe= rence > > > > > BSP, I have at-least tested on 3 different panels for us to prove= its > > > > > working. > > > > > > > > > > > Having some datasheet for the panels you had working would help= too. > > > > > > > > > > Unfortunately datasheet doesn't have any required information wha= t we > > > > > actually looking for. > > > > > > > > Not even the timings? How did you get that information then? > > > > > > datasheet has timing values, but this changes need controller > > > information about VBP register that I don't have. But again existing > > > VBP is not back porch for real, it's front porch. > > > > Yet, this breaks the existing setup. So again: >=20 > Was it with 4-lane or 2-lane panel? can you test it with 2-lane panel? > I can see the issue on 2-lane but the 4-lane working fine with this > patch even. It's a 4 lane display. Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --q7v7wduxjlqssxwi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXApz4AAKCRDj7w1vZxhR xa0MAQDINJywpBXTxw8UvHmXF3KPlaX6XTjqzx6fQVp5X/DPwwD/Z0QEHXJAd3EB dstdAPzyyxSR2BO86DpjKjX5ORODjwo= =pJW2 -----END PGP SIGNATURE----- --q7v7wduxjlqssxwi-- --===============0634873818822694515== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0634873818822694515==--