Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Faiz Abbas <faiz_abbas@ti.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	ulf.hansson@linaro.org, linux-kernel@vger.kernel.org,
	kishon@ti.com, t-kristo@ti.com, robh+dt@kernel.org,
	adrian.hunter@intel.com, michal.simek@xilinx.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-am654-base-board: Add MMC/SD support
Date: Sat, 8 Dec 2018 09:54:27 -0600	[thread overview]
Message-ID: <20181208155427.jmidz4vsw4k4qj36@akan> (raw)
In-Reply-To: <20181207084233.13700-3-faiz_abbas@ti.com>

On 14:12-20181207, Faiz Abbas wrote:

> +
> +&sdhci0 {
> +	status = "okay";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&main_mmc0_pins_default>;
> +	bus-width = <8>;
> +	non-removable;
> +	ti,driver-strength-ohm = <50>;

^^

> +};
> +
> +&sdhci1 {
> +	status = "okay";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&main_mmc1_pins_default>;
> +	ti,driver-strength-ohm = <50>;

NAK.

$ git checkout next-20181207
$ git grep ti,driver-strength-ohm Documentation
$

Nada.. And.. I think "new phy binding" probably introduces this.
[1] https://patchwork.kernel.org/project/linux-mmc/list/?series=53185

If your patches are'nt really ready, please send them as RFC, I am not
really in a mood to track the status of every single driver subsystem.

If your binding is not in linux next at the baremin, as far as I am
concerned, this is not ready, and should be RFC.

-- 
Regards,
Nishanth Menon

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2018-12-08 15:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-07  8:42 [PATCH 0/2] Add DT Support for MMCSD in Am65x-evm Faiz Abbas
2018-12-07  8:42 ` [PATCH 1/2] arm64: dts: ti: k3-am654: Add Support for MMC/SD Faiz Abbas
2018-12-08  5:26   ` Vignesh R
2018-12-08 15:45     ` Nishanth Menon
2018-12-10 13:30       ` Faiz Abbas
2018-12-07  8:42 ` [PATCH 2/2] arm64: dts: ti: k3-am654-base-board: Add MMC/SD support Faiz Abbas
2018-12-08 15:54   ` Nishanth Menon [this message]
2018-12-10  8:03     ` Sekhar Nori
2018-12-10 12:06       ` Nishanth Menon
2018-12-10 12:40         ` Sekhar Nori
2018-12-10 13:33           ` Faiz Abbas
2018-12-10 13:52             ` Nishanth Menon
2018-12-10 13:49           ` Nishanth Menon
2018-12-10 23:47         ` Tony Lindgren
2018-12-11 13:32           ` Sekhar Nori
2018-12-11  5:58   ` Vignesh R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181208155427.jmidz4vsw4k4qj36@akan \
    --to=nm@ti.com \
    --cc=adrian.hunter@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=faiz_abbas@ti.com \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=michal.simek@xilinx.com \
    --cc=robh+dt@kernel.org \
    --cc=t-kristo@ti.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox