* [PATCH] ARM: imx6qdl-sabresd: Use GPIO_ACTIVE_HIGH for regulators
@ 2018-12-06 10:36 Fabio Estevam
2018-12-09 12:39 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2018-12-06 10:36 UTC (permalink / raw)
To: shawnguo; +Cc: Fabio Estevam, linux-arm-kernel
Passing GPIO_ACTIVE_HIGH as GPIO flags for the GPIO controlled
regulator improves the readability, so use it instead of the
hardcoded number.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
index 187548d..8930aec 100644
--- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
@@ -22,7 +22,7 @@
regulator-name = "usb_otg_vbus";
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
- gpio = <&gpio3 22 0>;
+ gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>;
enable-active-high;
vin-supply = <&swbst_reg>;
};
@@ -32,7 +32,7 @@
regulator-name = "usb_h1_vbus";
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
- gpio = <&gpio1 29 0>;
+ gpio = <&gpio1 29 GPIO_ACTIVE_HIGH>;
enable-active-high;
vin-supply = <&swbst_reg>;
};
@@ -40,7 +40,7 @@
reg_audio: regulator-audio {
compatible = "regulator-fixed";
regulator-name = "wm8962-supply";
- gpio = <&gpio4 10 0>;
+ gpio = <&gpio4 10 GPIO_ACTIVE_HIGH>;
enable-active-high;
};
@@ -51,7 +51,7 @@
regulator-name = "MPCIE_3V3";
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
- gpio = <&gpio3 19 0>;
+ gpio = <&gpio3 19 GPIO_ACTIVE_HIGH>;
enable-active-high;
};
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: imx6qdl-sabresd: Use GPIO_ACTIVE_HIGH for regulators
2018-12-06 10:36 [PATCH] ARM: imx6qdl-sabresd: Use GPIO_ACTIVE_HIGH for regulators Fabio Estevam
@ 2018-12-09 12:39 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2018-12-09 12:39 UTC (permalink / raw)
To: Fabio Estevam; +Cc: linux-arm-kernel
On Thu, Dec 06, 2018 at 08:36:41AM -0200, Fabio Estevam wrote:
> Passing GPIO_ACTIVE_HIGH as GPIO flags for the GPIO controlled
> regulator improves the readability, so use it instead of the
> hardcoded number.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-09 12:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-06 10:36 [PATCH] ARM: imx6qdl-sabresd: Use GPIO_ACTIVE_HIGH for regulators Fabio Estevam
2018-12-09 12:39 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).