From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76AC6C65BAF for ; Mon, 10 Dec 2018 08:59:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3BA1E2082F for ; Mon, 10 Dec 2018 08:59:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rIyC0dP/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BA1E2082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t8yU4L0fMqEzbi+R6TRf0NsQKp5+bo8dCxebNgfzAQ0=; b=rIyC0dP/4Fj2q2 M/o0qNaU6COfAwo/NW8UKOOHMeTdwkd3RxP5VL+6hwpNzslkmWbOwBebkbs43eWDFYyVHofmTkZ1s Ax3JSox2aQU2QVrEd26z2c/L2FhsQeRzsJcTmWEwKtg5HejSQAypUeUyYOSPIfjQMZWhbpWAmUFWU 49IfWsNkZHaeXVfWuYsUtJf8bjYuh3ydCZNKkcdFeMOxXW42R7WFKXR+O5Q7xdykNTHHSxO66ep5K uGP/Ub8pes6Nm7zUETmTEyq+U/HeeZjwSiZbdCSUl2e65pfnwKg/xe9E9OHitZMtzFQ/Vse4cuoGE FTzWnlTa/ZGP2TAopbvw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gWHPM-0003Xc-O6; Mon, 10 Dec 2018 08:59:20 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gWHPJ-0003Tt-MT for linux-arm-kernel@lists.infradead.org; Mon, 10 Dec 2018 08:59:18 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E226A1596; Mon, 10 Dec 2018 00:59:06 -0800 (PST) Received: from localhost (e113682-lin.copenhagen.arm.com [10.32.144.41]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 536C73F575; Mon, 10 Dec 2018 00:59:06 -0800 (PST) Date: Mon, 10 Dec 2018 09:59:04 +0100 From: Christoffer Dall To: Anshuman Khandual Subject: Re: [PATCH v9 2/8] KVM: arm/arm64: Re-factor setting the Stage 2 entry to exec on fault Message-ID: <20181210085904.GC30263@e113682-lin.lund.arm.com> References: <20181031175745.18650-1-punit.agrawal@arm.com> <20181031175745.18650-3-punit.agrawal@arm.com> <12212830-ffc6-a0e0-5de6-3e6a15ed7141@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <12212830-ffc6-a0e0-5de6-3e6a15ed7141@arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181210_005917_737801_26FF2C67 X-CRM114-Status: GOOD ( 20.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: suzuki.poulose@arm.com, marc.zyngier@arm.com, Punit Agrawal , will.deacon@arm.com, linux-kernel@vger.kernel.org, punitagrawal@gmail.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 03, 2018 at 07:02:23PM +0530, Anshuman Khandual wrote: > > > On 10/31/2018 11:27 PM, Punit Agrawal wrote: > > Stage 2 fault handler marks a page as executable if it is handling an > > execution fault or if it was a permission fault in which case the > > executable bit needs to be preserved. > > > > The logic to decide if the page should be marked executable is > > duplicated for PMD and PTE entries. To avoid creating another copy > > when support for PUD hugepages is introduced refactor the code to > > share the checks needed to mark a page table entry as executable. > > > > Signed-off-by: Punit Agrawal > > Reviewed-by: Suzuki K Poulose > > Cc: Christoffer Dall > > Cc: Marc Zyngier > > --- > > virt/kvm/arm/mmu.c | 28 +++++++++++++++------------- > > 1 file changed, 15 insertions(+), 13 deletions(-) > > > > diff --git a/virt/kvm/arm/mmu.c b/virt/kvm/arm/mmu.c > > index 59595207c5e1..6912529946fb 100644 > > --- a/virt/kvm/arm/mmu.c > > +++ b/virt/kvm/arm/mmu.c > > @@ -1475,7 +1475,8 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, > > unsigned long fault_status) > > { > > int ret; > > - bool write_fault, exec_fault, writable, force_pte = false; > > + bool write_fault, writable, force_pte = false; > > + bool exec_fault, needs_exec; > > New line not required, still within 80 characters. > He's trying to logically group the two variables. I don't see a problem with that. Thanks, Christoffer _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel