From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Parthiban Nallathambi <pn@denx.de>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux@cubietech.com, wsa@the-dreams.de,
linux-kernel@vger.kernel.org, thomas.liau@actions-semi.com,
robh+dt@kernel.org, linux-i2c@vger.kernel.org, afaerber@suse.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/4] arm64: dts: actions: s700-cubieboard7: Enable I2C0 and I2C1
Date: Mon, 10 Dec 2018 19:20:44 +0530 [thread overview]
Message-ID: <20181210135044.GC25368@Mani-XPS-13-9360> (raw)
In-Reply-To: <20181126185821.2480449-5-pn@denx.de>
Hi Parthiban,
On Mon, Nov 26, 2018 at 07:58:21PM +0100, Parthiban Nallathambi wrote:
> Add pinctrl definitions for Actions Semiconductor S700 I2C controllers.
> Pinctrl definitions are only available for I2C0, I2C1 and I2C2.
> Enable I2C0 (PMIC), I2C1 (gyro, touchscreen) in cubieboard7.
>
> Signed-off-by: Parthiban Nallathambi <pn@denx.de>
> ---
> .../boot/dts/actions/s700-cubieboard7.dts | 53 +++++++++++++++++++
> 1 file changed, 53 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/actions/s700-cubieboard7.dts b/arch/arm64/boot/dts/actions/s700-cubieboard7.dts
> index 28f3f4a0f7f0..6a75fdd7ab42 100644
> --- a/arch/arm64/boot/dts/actions/s700-cubieboard7.dts
> +++ b/arch/arm64/boot/dts/actions/s700-cubieboard7.dts
> @@ -37,3 +37,56 @@
> &uart3 {
> status = "okay";
> };
> +
> +&i2c0 {
On the board DTS, node names should be sorted alphabetically!
Regards,
Mani
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c0_default>;
> +};
> +
> +&i2c1 {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c1_default>;
> +};
> +
> +&i2c2 {
> + status = "disabled";
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c2_default>;
> +};
> +
> +&pinctrl {
> + i2c0_default: i2c0_default {
> + pinmux {
> + groups = "i2c0_mfp";
> + function = "i2c0";
> + };
> + pinconf {
> + pins = "i2c0_sclk", "i2c0_sdata";
> + bias-pull-up;
> + };
> + };
> +
> + i2c1_default: i2c1_default {
> + pinmux {
> + groups = "i2c1_dummy";
> + function = "i2c1";
> + };
> + pinconf {
> + pins = "i2c1_sclk", "i2c1_sdata";
> + bias-pull-up;
> + };
> + };
> +
> + i2c2_default: i2c2_default {
> + pinmux {
> + groups = "i2c2_dummy";
> + function = "i2c2";
> + };
> + pinconf {
> + pins = "i2c2_sclk", "i2c2_sdata";
> + bias-pull-up;
> + };
> + };
> +};
> --
> 2.17.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-10 13:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 18:58 [PATCH v2 0/4] Add Actions Semi Owl family S700 I2C support Parthiban Nallathambi
2018-11-26 18:58 ` [PATCH v2 1/4] dt-bindings: i2c: Add S700 support for Actions Semi Soc's Parthiban Nallathambi
2018-12-10 13:43 ` Manivannan Sadhasivam
2018-11-26 18:58 ` [PATCH v2 2/4] i2c: Add Actions Semiconductor Owl family S700 I2C support Parthiban Nallathambi
2018-12-10 13:53 ` Manivannan Sadhasivam
2018-11-26 18:58 ` [PATCH v2 3/4] arm64: dts: actions: s700: Add I2C controller nodes Parthiban Nallathambi
2018-12-10 13:47 ` Manivannan Sadhasivam
2018-11-26 18:58 ` [PATCH v2 4/4] arm64: dts: actions: s700-cubieboard7: Enable I2C0 and I2C1 Parthiban Nallathambi
2018-12-10 13:50 ` Manivannan Sadhasivam [this message]
2018-12-10 11:25 ` [PATCH v2 0/4] Add Actions Semi Owl family S700 I2C support Parthiban Nallathambi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210135044.GC25368@Mani-XPS-13-9360 \
--to=manivannan.sadhasivam@linaro.org \
--cc=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@cubietech.com \
--cc=mark.rutland@arm.com \
--cc=pn@denx.de \
--cc=robh+dt@kernel.org \
--cc=thomas.liau@actions-semi.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox