mvebu: how to determine the address of the internal register window

mvebu: how to determine the address of the internal register window

[Uwe Kleine-König]

[-- Attachment #1.1.1: Type: text/plain, Size: 747 bytes --]

Hello,

using barebox on an mvebu machine the internal register window is moved
from 0xd0000000 to 0xf1000000. Compared to U-Boot the PCI Express BAR0
Internal Registers (on Armada 370: 0x40010 and 0x80010, on Armada XP a
few more) are not fixed which makes accessing pci devices fail. Instead
of letting barebox fix this up I'd like to make Linux ensure the
register is configured correctly.

I think the right place for that is mvebu_pcie_setup_wins which needs to do

	mvebu_writel(port, intregoffset, PCIE_BAR_LO_OFF(0));

I wonder however how I should determine the actual value to write here.
I didn't find a function that exports the offset of the internal
register window. Do you have a hint for me?

Best regards
Uwe


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: mvebu: how to determine the address of the internal register window

[Thomas Petazzoni]

Hello Uwe,

On Mon, 10 Dec 2018 18:09:38 +0100, Uwe Kleine-König wrote:

> using barebox on an mvebu machine the internal register window is moved
> from 0xd0000000 to 0xf1000000. Compared to U-Boot the PCI Express BAR0
> Internal Registers (on Armada 370: 0x40010 and 0x80010, on Armada XP a
> few more) are not fixed which makes accessing pci devices fail. Instead
> of letting barebox fix this up I'd like to make Linux ensure the
> register is configured correctly.
> 
> I think the right place for that is mvebu_pcie_setup_wins which needs to do
> 
> 	mvebu_writel(port, intregoffset, PCIE_BAR_LO_OFF(0));
> 
> I wonder however how I should determine the actual value to write here.
> I didn't find a function that exports the offset of the internal
> register window. Do you have a hint for me?

The base address of the internal registers is available in the Device
Tree:

        soc {
                ranges = <MBUS_ID(0xf0, 0x01) 0 0 0xf1000000 0x100000

See the 0xf1000000 here? That's the base address of the internal registers.

See also Documentation/devicetree/bindings/bus/mvebu-mbus.txt for more
details about this binding.

Alternatively, since the internal register window is always 1 MB large,
from the pci-mvebu driver, you can take the base address of any PCI
controller, do & ~0xFFFFF, and you get the base address of the internal
register window.

Does this helps?

Best regards

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel