From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3091BC5CFFE for ; Tue, 11 Dec 2018 15:44:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01F682082F for ; Tue, 11 Dec 2018 15:44:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="M/ApMR02" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01F682082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rnz0c1e2pqHtru7mXaiy1fQDxY7JizleBV3AL9cPxtI=; b=M/ApMR02KgJ+j8y9PGcn8VuhI TiM8yQRwPsjrQZ6tLG5OIyv+NpjFQSlpGwlgLH+lwntXMqyc+k8gVIosTQ/ks7PU3EN+W05LLVajP Nv7NAZD/X/bieBRplyJXmEux1yq1OI6YtHNWyRCX0aU6IFxQoH8DVX8VmuB0EIUeFAiGlyi/Z3xbq 0Zu8ScDukfQC9mm30ZFA8r7qKMEEd9gxzk+6BGQysu4kYJU/oSuj4I+gl1e8sv87ZjAJY0fuql5Gs nv0sHHltJHeSSOuyAS4VUjTkpBGU2xHaKbxgfL6XA7z2T44HFbQntAKzCCdIPff1Xea6B18S9DgJM xLcC8i69Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gWkDC-0007cc-6A; Tue, 11 Dec 2018 15:44:42 +0000 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gWkD8-0007bL-N0 for linux-arm-kernel@lists.infradead.org; Tue, 11 Dec 2018 15:44:40 +0000 Received: by mail.bootlin.com (Postfix, from userid 110) id 4A6EE20726; Tue, 11 Dec 2018 16:44:27 +0100 (CET) Received: from localhost (aaubervilliers-681-1-89-7.w90-88.abo.wanadoo.fr [90.88.30.7]) by mail.bootlin.com (Postfix) with ESMTPSA id D2AFE2039F; Tue, 11 Dec 2018 16:44:26 +0100 (CET) Date: Tue, 11 Dec 2018 16:44:27 +0100 From: Maxime Ripard To: Jagan Teki Subject: Re: [PATCH v3 3/6] media: sun6i: Set 300MHz mod clock for A64 Message-ID: <20181211154427.uekytnmp2wlgxwm2@flea> References: <20181210115246.8188-1-jagan@amarulasolutions.com> <20181210115246.8188-4-jagan@amarulasolutions.com> MIME-Version: 1.0 In-Reply-To: <20181210115246.8188-4-jagan@amarulasolutions.com> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181211_074438_885493_6BACA84C X-CRM114-Status: GOOD ( 14.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Michael Trimarchi , linux-sunxi , linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , Yong Deng , Mauro Carvalho Chehab , linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: multipart/mixed; boundary="===============0651423143968917101==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0651423143968917101== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="faq7xos5ziv2e6ih" Content-Disposition: inline --faq7xos5ziv2e6ih Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 10, 2018 at 05:22:43PM +0530, Jagan Teki wrote: > The default CSI_SCLK seems unable to drive the sensor to capture > the image, so update it to working clock rate 300MHz for A64. >=20 > Signed-off-by: Jagan Teki > --- > drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c b/drivers= /media/platform/sunxi/sun6i-csi/sun6i_csi.c > index bbe45e893722..4b872800b244 100644 > --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c > +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c > @@ -822,6 +822,11 @@ static int sun6i_csi_resource_request(struct sun6i_c= si_dev *sdev, > return PTR_ERR(sdev->clk_mod); > } > =20 > + /* A64 need 300MHz mod clock to operate properly */ > + if (of_device_is_compatible(pdev->dev.of_node, > + "allwinner,sun50i-a64-csi")) > + clk_set_rate_exclusive(sdev->clk_mod, 300000000); > + Where is that 300MHz coming from? You claim in your comment that it "operates properly", yet in your previous mail about this, you were saying that 1080p @30Hz is broken. Which one is it? Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --faq7xos5ziv2e6ih Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXA/bWwAKCRDj7w1vZxhR xdDMAP94RaXCEgkDKmVxakpYTM+VI1y0/E/u//LXpAldXToWTAEA7RxTw+Ks7v57 n5wjkBLnnQ0f0JWPzzSZZmA5AlLAUwY= =eSxP -----END PGP SIGNATURE----- --faq7xos5ziv2e6ih-- --===============0651423143968917101== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0651423143968917101==--