From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE7F5C6783B for ; Tue, 11 Dec 2018 20:21:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B36A420851 for ; Tue, 11 Dec 2018 20:21:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KwLWykNW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B36A420851 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=the-dreams.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sSDd1qEd/9v+yAG8LCfks73xquG4373fFP7B3WoEAQE=; b=KwLWykNW6ybSZblfSl7dZhkmJ ldF31NjM5+cYbZfmi2nMr+Cr4261nLyxDSTZQkjkVZ6OuwHl9NQJgbfzJjJu0P37FKFjeeQz5bC/1 DLf+ixoTHKaIAFCNqn79wUJnqEViHE0uB8SyXVi4jsQBxdoYkyD1IPV14jx4lLqMISKkfggxW5nHE OlCeHipn8Qyy6PVG7a9oLoT2vw8kXBTpIaj0Zy1W4dXFEwdmDrKiH9H3XAgbOu4yv4MQB34B1ZGlz D5B+rqwmPFXSCngYcOGmA6SAySy25mfgUAo0ERzMgOFA5onFq06KI7fkTwxfIyZ/eMqEP7fYC0Y8K RoNESm/XA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gWoWo-0005GN-OQ; Tue, 11 Dec 2018 20:21:14 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gWoWk-0005FF-8o; Tue, 11 Dec 2018 20:21:12 +0000 Received: from localhost (p54B334A7.dip0.t-ipconnect.de [84.179.52.167]) by pokefinder.org (Postfix) with ESMTPSA id 45CE94C0E90; Tue, 11 Dec 2018 21:20:59 +0100 (CET) Date: Tue, 11 Dec 2018 21:20:58 +0100 From: Wolfram Sang To: qii.wang@mediatek.com Subject: Re: [PATCH 2/5] i2c: mediatek: remove useless code and replace definitions Message-ID: <20181211202058.cd4wyz4so66iqspt@ninjato> References: <1543843974-4054-1-git-send-email-qii.wang@mediatek.com> <1543843974-4054-3-git-send-email-qii.wang@mediatek.com> MIME-Version: 1.0 In-Reply-To: <1543843974-4054-3-git-send-email-qii.wang@mediatek.com> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181211_122110_469928_8F726A47 X-CRM114-Status: GOOD ( 12.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, ryder.lee@mediatek.com, srv_heupstream@mediatek.com, leilk.liu@mediatek.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============6482182619375877498==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6482182619375877498== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rzzha3d23dmk6e55" Content-Disposition: inline --rzzha3d23dmk6e55 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 03, 2018 at 09:32:51PM +0800, qii.wang@mediatek.com wrote: > From: qii wang >=20 > Completion_done is useless when we don't use its return value, > so we remove it. Different speeds have been defined by macros, > so we use macros definitions. Those are two seperate patches, or? >=20 > Signed-off-by: qii wang > --- > drivers/i2c/busses/i2c-mt65xx.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt6= 5xx.c > index a74ef76..660de1e 100644 > --- a/drivers/i2c/busses/i2c-mt65xx.c > +++ b/drivers/i2c/busses/i2c-mt65xx.c > @@ -456,7 +456,7 @@ static int mtk_i2c_do_transfer(struct mtk_i2c *i2c, s= truct i2c_msg *msgs, > =20 > control_reg =3D readw(i2c->base + OFFSET_CONTROL) & > ~(I2C_CONTROL_DIR_CHANGE | I2C_CONTROL_RS); > - if ((i2c->speed_hz > 400000) || (left_num >=3D 1)) > + if ((i2c->speed_hz > MAX_FS_MODE_SPEED) || (left_num >=3D 1)) > control_reg |=3D I2C_CONTROL_RS; > =20 > if (i2c->op =3D=3D I2C_MASTER_WRRD) > @@ -465,7 +465,7 @@ static int mtk_i2c_do_transfer(struct mtk_i2c *i2c, s= truct i2c_msg *msgs, > writew(control_reg, i2c->base + OFFSET_CONTROL); > =20 > /* set start condition */ > - if (i2c->speed_hz <=3D 100000) > + if (i2c->speed_hz <=3D I2C_DEFAULT_SPEED) > writew(I2C_ST_START_CON, i2c->base + OFFSET_EXT_CONF); > else > writew(I2C_FS_START_CON, i2c->base + OFFSET_EXT_CONF); > @@ -642,8 +642,6 @@ static int mtk_i2c_do_transfer(struct mtk_i2c *i2c, s= truct i2c_msg *msgs, > return -ETIMEDOUT; > } > =20 > - completion_done(&i2c->msg_complete); > - > if (i2c->irq_stat & (I2C_HS_NACKERR | I2C_ACKERR)) { > dev_dbg(i2c->dev, "addr: %x, transfer ACK error\n", msgs->addr); > mtk_i2c_init_hw(i2c); > --=20 > 1.7.9.5 >=20 --rzzha3d23dmk6e55 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlwQHCoACgkQFA3kzBSg KbbLdw/+ODERxR+ceynTnAj6B+ZBYip0nSF+4P2h+GCcBlb0sM+5iW1aG9Koj2j2 QadPtWZ1riU6UfvKcoPyTmyPhZE+7B6YZ+wDVANZtXUU0FIzFPcYX7xcQ002bQ+A 1muAx5kuFfKd/uMXXF5BPcycswIo5tUJ58IFKdhl74qXPKapeKgH0ocse2vKItIs O2pfEDqy2TCEPJLaCO2f9TC78MDuKlOs7sE0cs1S3TPCu+0dfgfQeSROQJIwcRxH 4qn6LB4dgTssaHgrmOta2UfLmA1+DI9bWBlggdpDpjVmI5I+Q8sj/7m8nuvvQWuu axX68q4acAgOi5DIJZDKy6vhP1+VuWmdWEBCmPQtNcNRKHkyJr2twBQqH1E2uDo5 eISaxbq0dD58yYgop85/IBomC82jPCOcK9Xq7D69AtJWO42tpwoXo4FTe1nxqRNj hmdwd72Sj8Fe7URPoKfJlWMCKPhcXeJIg7acX3c6U6GIislR+Z2B78Hwnl1CZ9B9 PkuAo0K+JqF1orCKi4YeXCZHinUc9O/kuL7w5+jrp/F0DPJYQipwi2qEYD3fbh7g vwIJ5SC6wCc6qjW6Q1WaflkiuqbXOGt1nsbX5AGtFkovDYVtU0O/EcuNIpo7ytiE UAGLEUY45eAFOfij9o3p9Jazw1cZgv7YMb+9ScnPFdnsMKFkykg= =7YkG -----END PGP SIGNATURE----- --rzzha3d23dmk6e55-- --===============6482182619375877498== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6482182619375877498==--