From: Greg KH <gregkh@linuxfoundation.org>
To: Yangtao Li <tiny.windzz@gmail.com>
Cc: stefan.wahren@i2se.com, devel@driverdev.osuosl.org,
elder@kernel.org, keescook@chromium.org,
greybus-dev@lists.linaro.org, sparmaintainer@unisys.com,
johan@kernel.org, linux-kernel@vger.kernel.org, eric@anholt.net,
kernelpatch@126.com, viro@zeniv.linux.org.uk,
colin.king@canonical.com, pure.logic@nexus-software.ie,
natechancellor@gmail.com, david.kershner@unisys.com,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH] staging: convert to DEFINE_SHOW_ATTRIBUTE
Date: Wed, 12 Dec 2018 11:36:48 +0100 [thread overview]
Message-ID: <20181212103648.GA24255@kroah.com> (raw)
In-Reply-To: <20181209162742.19767-1-tiny.windzz@gmail.com>
On Sun, Dec 09, 2018 at 11:27:42AM -0500, Yangtao Li wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/staging/fwserial/fwserial.c | 32 +++----------------
> drivers/staging/greybus/loopback.c | 16 ++--------
> drivers/staging/rtlwifi/debug.c | 23 ++++---------
> .../staging/unisys/visorhba/visorhba_main.c | 14 +-------
> .../interface/vchiq_arm/vchiq_debugfs.c | 14 +-------
> 5 files changed, 14 insertions(+), 85 deletions(-)
Please break this up into one-patch-per-driver, so that the correct
people can properly review it, and you don't send patches out to people
who have no interested in other drivers.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2018-12-12 10:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-09 16:27 [PATCH] staging: convert to DEFINE_SHOW_ATTRIBUTE Yangtao Li
2018-12-12 10:36 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212103648.GA24255@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=colin.king@canonical.com \
--cc=david.kershner@unisys.com \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=eric@anholt.net \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=keescook@chromium.org \
--cc=kernelpatch@126.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=natechancellor@gmail.com \
--cc=pure.logic@nexus-software.ie \
--cc=sparmaintainer@unisys.com \
--cc=stefan.wahren@i2se.com \
--cc=tiny.windzz@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).