From: Will Deacon <will.deacon@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: add <asm/asm-prototypes.h>
Date: Wed, 12 Dec 2018 13:14:49 +0000 [thread overview]
Message-ID: <20181212131449.GA23641@edgewater-inn.cambridge.arm.com> (raw)
In-Reply-To: <20181212122219.29552-1-mark.rutland@arm.com>
On Wed, Dec 12, 2018 at 12:22:19PM +0000, Mark Rutland wrote:
> While we can export symbols from assembly files, CONFIG_MODVERIONS requires C
> declarations of anyhting that's exported.
>
> Let's account for this as other architectures do by placing these declarations
> in <asm/asm-prototypes.h>, which kbuild will automatically use to generate
> modversion information for assembly files.
>
> Since we already define most prototypes in existing headers, we simply need to
> include those headers in <asm/asm-prototypes.h>, and don't need to duplicate
> these.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> ---
> arch/arm64/include/asm/asm-prototypes.h | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
> create mode 100644 arch/arm64/include/asm/asm-prototypes.h
>
> Hi Will,
>
> I believe this covers all assembly exports for an arm64 allmodconfig. My laptop
> is rather slow at building all of that, so I can't confirm just yet, but I
> thought it was better to send this out in the mean time (or in case you can
> verify that locally).
Thanks, this fixes the allmodconfig build issues for me. I'll try to push it
out later today.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-12 13:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 12:22 [PATCH] arm64: add <asm/asm-prototypes.h> Mark Rutland
2018-12-12 13:14 ` Will Deacon [this message]
2018-12-12 13:15 ` Robin Murphy
2018-12-12 13:29 ` Mark Rutland
2018-12-12 13:33 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212131449.GA23641@edgewater-inn.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox