From: Shawn Guo <shawnguo@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de,
linux-imx@nxp.com
Subject: Re: [PATCH] ASoC: fsl: Fix SND_SOC_EUKREA_TLV320 build error on i.MX8M
Date: Thu, 13 Dec 2018 09:55:11 +0800 [thread overview]
Message-ID: <20181213015509.GA11997@dragon> (raw)
In-Reply-To: <1544647253-3806-1-git-send-email-festevam@gmail.com>
On Wed, Dec 12, 2018 at 06:40:53PM -0200, Fabio Estevam wrote:
> eukrea-tlv320.c machine driver runs on non-DT platforms
> and include <asm/mach-types.h> header file in order to be able
> to use some machine_is_eukrea_xxx() macros.
>
> Since commit 0e1532bfecf4 ("arm64: add basic Kconfig symbols for i.MX8")
> the ARCH_MXC symbol is visible on ARM64 too.
>
> Building it for ARM64 causes the following build error:
>
> sound/soc/fsl/eukrea-tlv320.c:28:10: fatal error: asm/mach-types.h: No such file or directory
>
> Avoid this error by not allowing to build the SND_SOC_EUKREA_TLV320
> driver when ARM64 is selected.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Hi Mark,
>
> Commit commit 0e1532bfecf4 ("arm64: add basic Kconfig symbols for i.MX8")
> is present in Shawn's tree, so maybe this should be taken by Shawn?
I would suggest you drop the mentioning of the commit from your commit
log, so that Mark can take the patch as a preparation for i.MX8 landing.
Shawn
>
> sound/soc/fsl/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> index 6ec19fb..2e75b5b 100644
> --- a/sound/soc/fsl/Kconfig
> +++ b/sound/soc/fsl/Kconfig
> @@ -221,7 +221,7 @@ config SND_SOC_PHYCORE_AC97
>
> config SND_SOC_EUKREA_TLV320
> tristate "Eukrea TLV320"
> - depends on ARCH_MXC && I2C
> + depends on ARCH_MXC && !ARM64 && I2C
> select SND_SOC_TLV320AIC23_I2C
> select SND_SOC_IMX_AUDMUX
> select SND_SOC_IMX_SSI
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-13 1:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 20:40 [PATCH] ASoC: fsl: Fix SND_SOC_EUKREA_TLV320 build error on i.MX8M Fabio Estevam
2018-12-13 1:55 ` Shawn Guo [this message]
2018-12-13 2:09 ` Fabio Estevam
2018-12-13 11:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213015509.GA11997@dragon \
--to=shawnguo@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox