Re: [PATCH v3 0/9] Regenerate arm64 defconfig for current kernel

Olof Johansson
2018-12-18T18:32:20Z

On Tue, Dec 18, 2018 at 7:28 AM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Fri, Dec 14, 2018 at 4:44 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote:
> >
> > On 13/12/2018 07:51, Olof Johansson wrote:
> >
> > > I've applied the patches from the series that were still needed. When
> > > re-running savedefconfig as part of patch 1, several of them were no longer
> > > applicable.
> >
> > FWIW, Arnd had suggested that the first patch should only deal with the
> > trivial case (moving options around), and subsequent patches should deal
> > with removed options, and corner cases.
> >
> > IIUC, you folded "trivial + removed" into a single patch. I suppose it
> > does make the commit log less bloated ;-)
> >
> > Thanks for merging the series.
>
> I suppose I should have asked for the patch to reorder the series to be
> the /last/ one in the series instead, to keep the useful changelog texts.

In my case I was a bit confused about what the series did when it was
first posted; I thought it actually enabled and disabled new
functionality, not that it "just" reflected changes that happened
implicit due to Kconfig changes. I.e. the patches that "fell out" of
the series were not actually making a difference to the generated
config, since they were setting what was now the default (or what
dependencies were no longer fulfilled).

So, I think there was a bit of miscommunication all around. Either way
-- thanks Marc for doing this work and following up on it, and
apologies for the confusion.

-Olof