From: Shawn Guo <shawnguo@kernel.org>
To: Olof Johansson <olof@lixom.net>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
Arnd Bergmann <arnd@arndb.de>, Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-imx@nxp.com, Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
linux-clk <linux-clk@vger.kernel.org>,
Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V11 1/7] clk: imx: add configuration option for mmio clks
Date: Thu, 13 Dec 2018 16:12:41 +0800 [thread overview]
Message-ID: <20181213081239.GB12458@dragon> (raw)
In-Reply-To: <CAOesGMhFtawJLpHmXbxvs=z+S1jVW8n2VQVv1gMcWicrOxDWdA@mail.gmail.com>
On Thu, Dec 13, 2018 at 04:02:34PM +0800, Olof Johansson wrote:
...
> > > diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
> > > index a47430b..8a9440a 100644
> > > --- a/drivers/clk/Makefile
> > > +++ b/drivers/clk/Makefile
> > > @@ -72,7 +72,7 @@ obj-$(CONFIG_ARCH_DAVINCI) += davinci/
> > > obj-$(CONFIG_H8300) += h8300/
> > > obj-$(CONFIG_ARCH_HISI) += hisilicon/
> > > obj-y += imgtec/
> > > -obj-$(CONFIG_ARCH_MXC) += imx/
> > > +obj-y += imx/
> > > obj-y += ingenic/
> > > obj-$(CONFIG_ARCH_K3) += keystone/
> > > obj-$(CONFIG_ARCH_KEYSTONE) += keystone/
> > > diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
> > > new file mode 100644
> > > index 0000000..37478ba
> > > --- /dev/null
> > > +++ b/drivers/clk/imx/Kconfig
> > > @@ -0,0 +1,5 @@
> > > +# SPDX-License-Identifier: GPL-2.0
> > > +# common clock support for NXP i.MX SoC family.
> > > +config MXC_CLK
> > > + bool
> > > + def_bool (ARCH_MXC && !ARM64) || (ARCH_MXC && ARM64 && SOC_IMX8MQ)
> >
> > Ok I looked closer, SOC_IMX8MQ is only being introduced now and has only
> > been in linux-next for a few days. Having such a config symbol is highly
> > unusual for arm64 code. Has that been accepted by arm-soc? I don't know
> > why it would be because we don't add SoC specific config options
> > anymore. I imagine it will be rejected and we'll need to have this new
> > MXC_CLK config be enabled in the defconfig instead of selected from the
> > arch layer.
> >
> > Given all that, is there any damage if this is just a def_bool ARCH_MXC
> > right now? If it's enabled on the platforms that don't use it because
> > they have SCU, does it actually matter? Or we just get some code bloat?
> > If it's just some extra code, then even more reason to make a user
> > visible config option that can be selected in the configurations that
> > care to save some space.
>
> On arm64 we generally add an ARCH_<family> and leave it at that. So,
> ARCH_MXC would be suitable, but we shouldn't add more finegrained than
> that.
Olof,
I'm just about to send pull request for i.MX8MQ support, which
introduced SOC_IMX8MQ option. It sounds like we should rework the
patches to get SOC_IMX8MQ killed?
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-13 8:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 1:07 [PATCH V11 0/7] clk: imx: add imx8qxp clock support Aisheng Dong
2018-12-13 1:07 ` [PATCH V11 1/7] clk: imx: add configuration option for mmio clks Aisheng Dong
2018-12-13 7:57 ` Stephen Boyd
2018-12-13 8:02 ` Olof Johansson
2018-12-13 8:12 ` Shawn Guo [this message]
2018-12-13 12:04 ` Abel Vesa
2018-12-14 1:36 ` Olof Johansson
2018-12-13 12:49 ` Aisheng Dong
2018-12-14 1:32 ` Stephen Boyd
2018-12-14 1:50 ` Aisheng Dong
2018-12-13 1:07 ` [PATCH V11 2/7] clk: imx: add scu clock common part Aisheng Dong
2018-12-13 7:48 ` Stephen Boyd
2018-12-13 11:19 ` Aisheng Dong
2018-12-14 1:30 ` Stephen Boyd
2018-12-14 1:44 ` Aisheng Dong
2018-12-14 2:17 ` Stephen Boyd
2018-12-14 2:28 ` Aisheng Dong
2018-12-13 1:07 ` [PATCH V11 3/7] dt-bindings: clock: imx8qxp: add SCU clock IDs Aisheng Dong
2018-12-13 7:59 ` Stephen Boyd
2018-12-13 8:31 ` Shawn Guo
2018-12-13 11:22 ` Aisheng Dong
2018-12-13 1:08 ` [PATCH V11 4/7] clk: imx: add imx8qxp clk driver Aisheng Dong
2018-12-13 1:08 ` [PATCH V11 5/7] dt-bindings: clock: add imx8qxp lpcg clock binding Aisheng Dong
2018-12-13 7:59 ` Stephen Boyd
2018-12-13 1:08 ` [PATCH V11 6/7] clk: imx: add lpcg clock support Aisheng Dong
2018-12-13 1:08 ` [PATCH V11 7/7] clk: imx: add imx8qxp lpcg driver Aisheng Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213081239.GB12458@dragon \
--to=shawnguo@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=arnd@arndb.de \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=mturquette@baylibre.com \
--cc=olof@lixom.net \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).