From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Liviu Dudau <liviu.dudau@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: vexpress/realview: consolidate immitation CPU hotplug
Date: Thu, 13 Dec 2018 15:53:54 +0000 [thread overview]
Message-ID: <20181213155354.GA26090@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20181213154133.GA17614@e107155-lin>
On Thu, Dec 13, 2018 at 03:41:44PM +0000, Sudeep Holla wrote:
> On Thu, Dec 13, 2018 at 12:32:16PM +0000, Russell King wrote:
> > The only difference between the hotplug implementation for Realview
> > and Versatile Express are the bit in the auxiliary control register
> > to disable coherency. Combine the two implentations accounting for
> > that difference.
> >
> > Rename the functions to try to discourage cargo-cult copying of this
> > code.
> >
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> > ---
> > Please note that this hasn't been compile tested yet.
> >
> Yes, I had a fix a missed callee site that needs to use unified
> versatile_immitation_cpu_die to compile it.
Yep, there's also a missing #include that I found while building Realview.
> > diff --git a/arch/arm/mach-vexpress/platsmp.c b/arch/arm/mach-vexpress/platsmp.c
> > index 742499bac6d0..63c9784f063f 100644
> > --- a/arch/arm/mach-vexpress/platsmp.c
> > +++ b/arch/arm/mach-vexpress/platsmp.c
> > @@ -82,6 +82,13 @@ static void __init vexpress_smp_dt_prepare_cpus(unsigned int max_cpus)
> > vexpress_flags_set(__pa_symbol(versatile_secondary_startup));
> > }
> >
> > +#ifdef CONFIG_HOTPLUG_CPU
> > +static void vexpress_cpu_die(unsigned int cpu)
> > +{
> > + versatile_cpu_die(cpu, 0x40);
>
> This should be versatile_immitation_cpu_die(cpu, 0x40)
Yep, thanks.
> With that, it looks fine and passed a hotplug tests for a quick/short period
> on my TC2. So for mach-vexpress part,
>
> Tested-by: Sudeep Holla <sudeep.holla@arm.com>
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Thanks.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2018-12-13 15:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 12:32 [PATCH] ARM: vexpress/realview: consolidate immitation CPU hotplug Russell King
2018-12-13 15:41 ` Sudeep Holla
2018-12-13 15:53 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213155354.GA26090@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).