From: Simon Horman <horms@verge.net.au>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: linux-renesas-soc@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver
Date: Mon, 17 Dec 2018 10:21:38 +0100 [thread overview]
Message-ID: <20181217092138.g5kwssfxabiw7g7f@verge.net.au> (raw)
In-Reply-To: <871s6gk0mr.wl-kuninori.morimoto.gx@renesas.com>
On Mon, Dec 17, 2018 at 05:49:34PM +0900, Kuninori Morimoto wrote:
>
> Hi Simon
>
> > Using renesas_defconfig as a base I find that without enabling
> > CONFIG_SND_SIMPLE_SCU_CARD the following are enabled:
> >
> > CONFIG_SND_AUDIO_GRAPH_CARD
> > CONFIG_SND_SIMPLE_CARD
> >
> > But I see:
> >
> > [ 12.209793] ALSA device list:
> > [ 12.212799] No soundcards found.
> >
> > With CONFIG_SND_SIMPLE_SCU_CARD also enabled (in the defconfig) I see:
> >
> > [ 14.087191] ALSA device list:
> > [ 14.090195] #0: rsnd-ak4613
>
> Thanks.
> 56629fcba94c698d8c5be3413981506479566869
> ("arm64: dts: renesas: ebisu: Enable Audio")
> is using "simple-scu-audio-card", but it should be "simple-audio-card".
> Can you add and test this patch ?
> CONFIG_SND_SIMPLE_SCU_CARD is no longer needed, I think.
Thanks Morimoto-san,
I confirm that Sound on Ebisu-4D appears to work with a)
CONFIG_SND_SIMPLE_SCU_CARD disabled and b) the following patch applied.
>
> --------------
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> index 62bdddc..649d3fd 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> @@ -159,16 +159,13 @@
> };
>
> rsnd_ak4613: sound {
> - compatible = "simple-scu-audio-card";
> + compatible = "simple-audio-card";
>
> simple-audio-card,name = "rsnd-ak4613";
> simple-audio-card,format = "left_j";
> simple-audio-card,bitclock-master = <&sndcpu>;
> simple-audio-card,frame-master = <&sndcpu>;
>
> - simple-audio-card,prefix = "ak4613";
> - simple-audio-card,routing = "ak4613 Playback", "DAI0 Playback",
> - "DAI0 Capture", "ak4613 Capture";
> sndcpu: simple-audio-card,cpu {
> sound-dai = <&rcar_sound>;
> };
> --------------
>
>
> Best regards
> ---
> Kuninori Morimoto
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-17 9:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 11:56 [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver Simon Horman
2018-12-17 0:29 ` Kuninori Morimoto
2018-12-17 8:36 ` Simon Horman
2018-12-17 8:49 ` Kuninori Morimoto
2018-12-17 9:21 ` Simon Horman [this message]
2018-12-17 23:01 ` Kuninori Morimoto
2018-12-18 11:07 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2018-12-06 21:57 [GIT PULL] Renesas ARM64 Based SoC Defconfig Updates for v4.21 Simon Horman
2018-12-06 21:57 ` [PATCH 2/3] arm64: defconfig: Enable scu-simple-card driver Simon Horman
2018-12-07 8:28 ` Geert Uytterhoeven
2018-12-07 22:06 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217092138.g5kwssfxabiw7g7f@verge.net.au \
--to=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox