From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B94F1C43387 for ; Tue, 18 Dec 2018 16:20:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8571421841 for ; Tue, 18 Dec 2018 16:20:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MkOG+0py"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="qEH3GAjW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8571421841 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mXt7Nlol2mt52fhatCu1/t8eQ2kd4bo9CLVa+/jacNc=; b=MkOG+0py2ArHePRc1CDctqdVk De6gLHnlqXVMgcOsI0Ao57BHNEAPVKCBTwjwltOZLMQiwOlzNSVduy5hf56I80c4I4i0gckfVfeXC jq3mhkejicNfoNLFe584bOt9zsbBvThu/jfX0OejN5YN+nM7EGEihnmHbWrYxEo7DlOrsUBY369HT 4ujrK8BCHDKYVN5dWcCBNDKR7fSSTFS/+qXQk6GzZ9Cfp36NGY1snz7ZkkapSgj/HYIr9kqrqRzwH f+ku4+otWqDkrbIr5EuN0mkz5aoy0EswOQheEaaxnrihsU+nWT78SXvgOz4TsBvxnMPqp+7BIFLXI JP3rNaOLw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gZI6o-00088A-34; Tue, 18 Dec 2018 16:20:38 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gZI6l-00086d-9D for linux-arm-kernel@lists.infradead.org; Tue, 18 Dec 2018 16:20:36 +0000 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 16F1421841; Tue, 18 Dec 2018 16:20:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545150024; bh=O0eLo7REp3cQc0ofV/CFX8S+nD7DIju1/SYBRr7ei8E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qEH3GAjWwQ3jKv6QYvrX+J5HrdQfKYNRiOx0PuXBnNSpYU+ixyOa1xkHyGrxdUpXQ 7Oks1hfSrIzXh/NM+ZrgWGcUDMZViseGOImPUcUhEWALBDMBN1qzVF0JfHahXRK2Gj iawOG3LRFtKGdnA5VUFWPmiCK8F2pdaeLMNBRJKI= Date: Tue, 18 Dec 2018 11:20:21 -0500 From: Sasha Levin To: Greg Kroah-Hartman Subject: Re: [PATCH 0/7] v4.19-stable randconfig fixes Message-ID: <20181218162021.GZ2746@sasha-vm> References: <20181214221023.3878670-1-arnd@arndb.de> <20181218002028.GX2746@sasha-vm> <20181218151230.GA30844@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181218151230.GA30844@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181218_082035_359819_C8D51AB1 X-CRM114-Status: GOOD ( 18.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-aspeed@lists.ozlabs.org, Peter Zijlstra , David Brown , Srinivas Kandagatla , linux-i2c@vger.kernel.org, "James E.J. Bottomley" , Daniel Drake , linux-scsi@vger.kernel.org, Jens Frederich , openbmc@lists.ozlabs.org, Ingo Molnar , Andy Gross , devicetree@vger.kernel.org, Arnd Bergmann , linux-arm-msm@vger.kernel.org, Lubomir Rintel , dou_liyang@163.com, Rob Herring , bp@alien8.de, Vincent Guittot , linux-arm-kernel@lists.infradead.org, "Martin K. Petersen" , Andrew Jeffery , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Rob Clark , freedreno@lists.freedesktop.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 18, 2018 at 04:12:30PM +0100, Greg Kroah-Hartman wrote: >On Mon, Dec 17, 2018 at 07:20:28PM -0500, Sasha Levin wrote: >> On Fri, Dec 14, 2018 at 11:10:05PM +0100, Arnd Bergmann wrote: >> > Hi Greg, >> > >> > I did some randconfig testing on linux-4.19 arm/arm64/x86. So far I needed >> > 27 patches, most of which are also still needed in mainline Linux. I >> > had submitted some before, and others were not submitted previously >> > for some reason. I'll try to get those fixed in mainline and then >> > make sure we get them into 4.19 as well. >> > >> > This series for now contains four patches that did make it into mainline: >> > >> > 2e6ae11dd0d1 ("slimbus: ngd: mark PM functions as __maybe_unused") >> > 33f49571d750 ("staging: olpc_dcon: add a missing dependency") >> > 0eeec01488da ("scsi: raid_attrs: fix unused variable warning") >> > 11d4afd4ff66 ("sched/pelt: Fix warning and clean up IRQ PELT config") >> > >> > Feel free to either cherry-pick those from mainline or apply the >> > patch from this series, whichever works best for you. >> > >> > The other three patches are for warnings in code that got removed in >> > mainline kernels: >> > >> > 3e9efc3299dd ("i2c: aspeed: Handle master/slave combined irq events properly") >> > 972910948fb6 ("ARM: dts: qcom: Remove Arrow SD600 eval board") >> > effec874792f ("drm/msm/dpu: Remove dpu_dbg") >> > >> > My feeling was that it's safer to just address the warning by fixing >> > the code correctly in each of these cases, but if you disagree, >> > applying the mainline change should work equally well, so decide >> > for yourself. >> >> Thanks Arnd, I took the series as is. >> >> We really need to discuss how -stable deals with removed code upstream. >> For some cases, we should probably follow suit and remove it from >> -stable as well (I'm mostly thinking dodgy code with potential security >> issues). > >It would be nice to do that at times (like lustre and ipx), but it's >good to keep that code around as maybe someone is using it? I don't >know, it's a tough call... Yeah, it's really a case-by-case basis. I'm really concerned about an unmaintained piece of code in stable kernels, no one actually fixes bug in it. With the example here where that eval board was removed because no one was using it is a great example of code we should be removing from stable trees as well. If no one is using it - great! but if someone does, then the removal should be reverted upstream as well. -- Thanks, Sasha _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel