* [PATCH v2 0/2] arm64: dts: sdm845: Add sdm845 GPU interconnect @ 2018-12-14 22:16 Jordan Crouse 2018-12-14 22:16 ` [PATCH v2 1/2] dt-bindings: drm/msm/a6xx: Document interconnect properties for GPU Jordan Crouse 2018-12-14 22:16 ` [PATCH v2 2/2] arm64: dts: sdm845: Add interconnect " Jordan Crouse 0 siblings, 2 replies; 9+ messages in thread From: Jordan Crouse @ 2018-12-14 22:16 UTC (permalink / raw) To: freedreno, dri-devel Cc: nm, devicetree, rnayak, linux-pm, linux-arm-msm, dianders, vireshk, georgi.djakov, linux-arm-kernel Two quick patches to document and add an interconnect port definition for the sdm845 GPU. This is based on the base GPU DT changes: https://patchwork.freedesktop.org/series/39308/ As well as the DT nodes from Georgi: https://patchwork.kernel.org/patch/10719483/ v2: Fix interconnect supplier to match latest per Doug Anderson *** BLURB HERE *** Jordan Crouse (2): dt-bindings: drm/msm/a6xx: Document interconnect properties for GPU arm64: dts: sdm845: Add interconnect for GPU Documentation/devicetree/bindings/display/msm/gpu.txt | 6 ++++++ arch/arm64/boot/dts/qcom/sdm845.dtsi | 3 +++ 2 files changed, 9 insertions(+) -- 2.18.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/2] dt-bindings: drm/msm/a6xx: Document interconnect properties for GPU 2018-12-14 22:16 [PATCH v2 0/2] arm64: dts: sdm845: Add sdm845 GPU interconnect Jordan Crouse @ 2018-12-14 22:16 ` Jordan Crouse 2018-12-14 23:58 ` Doug Anderson 2018-12-18 17:22 ` Rob Herring 2018-12-14 22:16 ` [PATCH v2 2/2] arm64: dts: sdm845: Add interconnect " Jordan Crouse 1 sibling, 2 replies; 9+ messages in thread From: Jordan Crouse @ 2018-12-14 22:16 UTC (permalink / raw) To: freedreno, dri-devel Cc: nm, devicetree, rnayak, linux-pm, linux-arm-msm, dianders, vireshk, georgi.djakov, linux-arm-kernel Add documentation for the interconnect and interconnect-names bindings for the GPU node as detailed by bindings/interconnect/interconnect.txt. Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org> --- Documentation/devicetree/bindings/display/msm/gpu.txt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/gpu.txt b/Documentation/devicetree/bindings/display/msm/gpu.txt index 8d9415180c22..19b5ae459fdb 100644 --- a/Documentation/devicetree/bindings/display/msm/gpu.txt +++ b/Documentation/devicetree/bindings/display/msm/gpu.txt @@ -19,6 +19,9 @@ Required properties: * "mem_iface" - iommus: optional phandle to an adreno iommu instance - operating-points-v2: optional phandle to the OPP operating points +- interconnect: optional phandle to a interconnect provider. See + ../interconnect/interconnect.txt for details. +- interconnect-names: Name string for the interconnects. - qcom,gmu: For a6xx and newer targets a phandle to the GMU device that will control the power for the GPU @@ -68,6 +71,9 @@ Example a6xx (with GMU): operating-points-v2 = <&gpu_opp_table>; + interconnects = <&rsc_hlos MASTER_GFX3D &rsc_hlos SLAVE_EBI1>; + interconnect-names = "gfx-mem"; + qcom,gmu = <&gmu>; }; }; -- 2.18.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: drm/msm/a6xx: Document interconnect properties for GPU 2018-12-14 22:16 ` [PATCH v2 1/2] dt-bindings: drm/msm/a6xx: Document interconnect properties for GPU Jordan Crouse @ 2018-12-14 23:58 ` Doug Anderson 2018-12-15 0:00 ` Doug Anderson 2018-12-18 17:22 ` Rob Herring 1 sibling, 1 reply; 9+ messages in thread From: Doug Anderson @ 2018-12-14 23:58 UTC (permalink / raw) To: Jordan Crouse Cc: Nishanth Menon, devicetree, Rajendra Nayak, linux-pm, linux-arm-msm, dri-devel, vireshk, freedreno, Georgi Djakov, Linux ARM Hi, On Fri, Dec 14, 2018 at 2:16 PM Jordan Crouse <jcrouse@codeaurora.org> wrote: > > Add documentation for the interconnect and interconnect-names bindings > for the GPU node as detailed by bindings/interconnect/interconnect.txt. > > Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org> > --- > Documentation/devicetree/bindings/display/msm/gpu.txt | 6 ++++++ > 1 file changed, 6 insertions(+) Looks good to me. This could go into Andy's tree as soon as Georgi's series lands somewhere. Reviewed-by: Douglas Anderson <dianders@chromium.org> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: drm/msm/a6xx: Document interconnect properties for GPU 2018-12-14 23:58 ` Doug Anderson @ 2018-12-15 0:00 ` Doug Anderson 0 siblings, 0 replies; 9+ messages in thread From: Doug Anderson @ 2018-12-15 0:00 UTC (permalink / raw) To: Jordan Crouse Cc: Nishanth Menon, devicetree, Rajendra Nayak, linux-pm, linux-arm-msm, dri-devel, vireshk, freedreno, Georgi Djakov, Linux ARM Hi, On Fri, Dec 14, 2018 at 3:58 PM Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Fri, Dec 14, 2018 at 2:16 PM Jordan Crouse <jcrouse@codeaurora.org> wrote: > > > > Add documentation for the interconnect and interconnect-names bindings > > for the GPU node as detailed by bindings/interconnect/interconnect.txt. > > > > Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org> > > --- > > Documentation/devicetree/bindings/display/msm/gpu.txt | 6 ++++++ > > 1 file changed, 6 insertions(+) > > Looks good to me. This could go into Andy's tree as soon as Georgi's > series lands somewhere. > > Reviewed-by: Douglas Anderson <dianders@chromium.org> To correct myself, this maybe should go through Georgi's tree together with <https://patchwork.kernel.org/patch/10718587/>. It's the actual dts that would go into Andy's tree. -Doug _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: drm/msm/a6xx: Document interconnect properties for GPU 2018-12-14 22:16 ` [PATCH v2 1/2] dt-bindings: drm/msm/a6xx: Document interconnect properties for GPU Jordan Crouse 2018-12-14 23:58 ` Doug Anderson @ 2018-12-18 17:22 ` Rob Herring 2018-12-18 18:07 ` Jordan Crouse 1 sibling, 1 reply; 9+ messages in thread From: Rob Herring @ 2018-12-18 17:22 UTC (permalink / raw) To: Jordan Crouse Cc: nm, devicetree, rnayak, linux-pm, linux-arm-msm, dianders, dri-devel, vireshk, freedreno, georgi.djakov, linux-arm-kernel On Fri, Dec 14, 2018 at 03:16:39PM -0700, Jordan Crouse wrote: > Add documentation for the interconnect and interconnect-names bindings > for the GPU node as detailed by bindings/interconnect/interconnect.txt. > > Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org> > --- > Documentation/devicetree/bindings/display/msm/gpu.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/gpu.txt b/Documentation/devicetree/bindings/display/msm/gpu.txt > index 8d9415180c22..19b5ae459fdb 100644 > --- a/Documentation/devicetree/bindings/display/msm/gpu.txt > +++ b/Documentation/devicetree/bindings/display/msm/gpu.txt > @@ -19,6 +19,9 @@ Required properties: > * "mem_iface" > - iommus: optional phandle to an adreno iommu instance > - operating-points-v2: optional phandle to the OPP operating points > +- interconnect: optional phandle to a interconnect provider. See > + ../interconnect/interconnect.txt for details. > +- interconnect-names: Name string for the interconnects. > - qcom,gmu: For a6xx and newer targets a phandle to the GMU device that will > control the power for the GPU > > @@ -68,6 +71,9 @@ Example a6xx (with GMU): > > operating-points-v2 = <&gpu_opp_table>; > > + interconnects = <&rsc_hlos MASTER_GFX3D &rsc_hlos SLAVE_EBI1>; > + interconnect-names = "gfx-mem"; There's not really any point to having *-names when there is only 1 value. > + > qcom,gmu = <&gmu>; > }; > }; > -- > 2.18.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: drm/msm/a6xx: Document interconnect properties for GPU 2018-12-18 17:22 ` Rob Herring @ 2018-12-18 18:07 ` Jordan Crouse 2018-12-18 21:01 ` Rob Herring 0 siblings, 1 reply; 9+ messages in thread From: Jordan Crouse @ 2018-12-18 18:07 UTC (permalink / raw) To: Rob Herring Cc: nm, devicetree, rnayak, linux-pm, linux-arm-msm, dianders, dri-devel, vireshk, freedreno, georgi.djakov, linux-arm-kernel On Tue, Dec 18, 2018 at 11:22:01AM -0600, Rob Herring wrote: > On Fri, Dec 14, 2018 at 03:16:39PM -0700, Jordan Crouse wrote: > > Add documentation for the interconnect and interconnect-names bindings > > for the GPU node as detailed by bindings/interconnect/interconnect.txt. > > > > Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org> > > --- > > Documentation/devicetree/bindings/display/msm/gpu.txt | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/gpu.txt b/Documentation/devicetree/bindings/display/msm/gpu.txt > > index 8d9415180c22..19b5ae459fdb 100644 > > --- a/Documentation/devicetree/bindings/display/msm/gpu.txt > > +++ b/Documentation/devicetree/bindings/display/msm/gpu.txt > > @@ -19,6 +19,9 @@ Required properties: > > * "mem_iface" > > - iommus: optional phandle to an adreno iommu instance > > - operating-points-v2: optional phandle to the OPP operating points > > +- interconnect: optional phandle to a interconnect provider. See > > + ../interconnect/interconnect.txt for details. > > +- interconnect-names: Name string for the interconnects. > > - qcom,gmu: For a6xx and newer targets a phandle to the GMU device that will > > control the power for the GPU > > > > @@ -68,6 +71,9 @@ Example a6xx (with GMU): > > > > operating-points-v2 = <&gpu_opp_table>; > > > > + interconnects = <&rsc_hlos MASTER_GFX3D &rsc_hlos SLAVE_EBI1>; > > + interconnect-names = "gfx-mem"; > > There's not really any point to having *-names when there is only 1 > value. For the moment we can only look up the path from the DT by name. I guess we could add an lookup by index but I'm not sure if that had already been considered and rejected. Jordan -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: drm/msm/a6xx: Document interconnect properties for GPU 2018-12-18 18:07 ` Jordan Crouse @ 2018-12-18 21:01 ` Rob Herring 0 siblings, 0 replies; 9+ messages in thread From: Rob Herring @ 2018-12-18 21:01 UTC (permalink / raw) To: freedreno, dri-devel, Nishanth Menon, devicetree, Rajendra Nayak, open list:THERMAL, linux-arm-msm, Doug Anderson, Viresh Kumar, moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE, Georgi Djakov On Tue, Dec 18, 2018 at 12:07 PM Jordan Crouse <jcrouse@codeaurora.org> wrote: > > On Tue, Dec 18, 2018 at 11:22:01AM -0600, Rob Herring wrote: > > On Fri, Dec 14, 2018 at 03:16:39PM -0700, Jordan Crouse wrote: > > > Add documentation for the interconnect and interconnect-names bindings > > > for the GPU node as detailed by bindings/interconnect/interconnect.txt. > > > > > > Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org> > > > --- > > > Documentation/devicetree/bindings/display/msm/gpu.txt | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/msm/gpu.txt b/Documentation/devicetree/bindings/display/msm/gpu.txt > > > index 8d9415180c22..19b5ae459fdb 100644 > > > --- a/Documentation/devicetree/bindings/display/msm/gpu.txt > > > +++ b/Documentation/devicetree/bindings/display/msm/gpu.txt > > > @@ -19,6 +19,9 @@ Required properties: > > > * "mem_iface" > > > - iommus: optional phandle to an adreno iommu instance > > > - operating-points-v2: optional phandle to the OPP operating points > > > +- interconnect: optional phandle to a interconnect provider. See > > > + ../interconnect/interconnect.txt for details. > > > +- interconnect-names: Name string for the interconnects. > > > - qcom,gmu: For a6xx and newer targets a phandle to the GMU device that will > > > control the power for the GPU > > > > > > @@ -68,6 +71,9 @@ Example a6xx (with GMU): > > > > > > operating-points-v2 = <&gpu_opp_table>; > > > > > > + interconnects = <&rsc_hlos MASTER_GFX3D &rsc_hlos SLAVE_EBI1>; > > > + interconnect-names = "gfx-mem"; > > > > There's not really any point to having *-names when there is only 1 > > value. > > For the moment we can only look up the path from the DT by name. I guess we > could add an lookup by index but I'm not sure if that had already been > considered and rejected. You don't have to support lookup by index, just support a NULL name. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 2/2] arm64: dts: sdm845: Add interconnect for GPU 2018-12-14 22:16 [PATCH v2 0/2] arm64: dts: sdm845: Add sdm845 GPU interconnect Jordan Crouse 2018-12-14 22:16 ` [PATCH v2 1/2] dt-bindings: drm/msm/a6xx: Document interconnect properties for GPU Jordan Crouse @ 2018-12-14 22:16 ` Jordan Crouse 2018-12-14 23:59 ` Doug Anderson 1 sibling, 1 reply; 9+ messages in thread From: Jordan Crouse @ 2018-12-14 22:16 UTC (permalink / raw) To: freedreno, dri-devel Cc: nm, devicetree, rnayak, linux-pm, linux-arm-msm, dianders, vireshk, georgi.djakov, linux-arm-kernel Define an interconnect port for the GPU to set bus capabilities. Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org> --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 0a5ddfc4c59b..2acfea87716c 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -1370,6 +1370,9 @@ operating-points-v2 = <&gpu_opp_table>; + interconnects = <&rsc_hlos MASTER_GFX3D &rsc_hlos SLAVE_EBI1>; + interconnect-names = "gfx-mem"; + qcom,gmu = <&gmu>; gpu_opp_table: opp-table { -- 2.18.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] arm64: dts: sdm845: Add interconnect for GPU 2018-12-14 22:16 ` [PATCH v2 2/2] arm64: dts: sdm845: Add interconnect " Jordan Crouse @ 2018-12-14 23:59 ` Doug Anderson 0 siblings, 0 replies; 9+ messages in thread From: Doug Anderson @ 2018-12-14 23:59 UTC (permalink / raw) To: Jordan Crouse Cc: Nishanth Menon, devicetree, Rajendra Nayak, linux-pm, linux-arm-msm, dri-devel, vireshk, freedreno, Georgi Djakov, Linux ARM Hi, On Fri, Dec 14, 2018 at 2:16 PM Jordan Crouse <jcrouse@codeaurora.org> wrote: > > Define an interconnect port for the GPU to set bus > capabilities. > > Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 3 +++ > 1 file changed, 3 insertions(+) Looks good to me. This could go into Andy's tree as soon as Georgi's series lands somewhere. Reviewed-by: Douglas Anderson <dianders@chromium.org> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-12-18 21:01 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-12-14 22:16 [PATCH v2 0/2] arm64: dts: sdm845: Add sdm845 GPU interconnect Jordan Crouse 2018-12-14 22:16 ` [PATCH v2 1/2] dt-bindings: drm/msm/a6xx: Document interconnect properties for GPU Jordan Crouse 2018-12-14 23:58 ` Doug Anderson 2018-12-15 0:00 ` Doug Anderson 2018-12-18 17:22 ` Rob Herring 2018-12-18 18:07 ` Jordan Crouse 2018-12-18 21:01 ` Rob Herring 2018-12-14 22:16 ` [PATCH v2 2/2] arm64: dts: sdm845: Add interconnect " Jordan Crouse 2018-12-14 23:59 ` Doug Anderson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).