From: Jordan Crouse <jcrouse@codeaurora.org>
To: Rob Herring <robh@kernel.org>
Cc: nm@ti.com, devicetree@vger.kernel.org, rnayak@codeaurora.org,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
dianders@chromium.org, dri-devel@lists.freedesktop.org,
vireshk@kernel.org, freedreno@lists.freedesktop.org,
georgi.djakov@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] dt-bindings: drm/msm/a6xx: Document interconnect properties for GPU
Date: Tue, 18 Dec 2018 11:07:47 -0700 [thread overview]
Message-ID: <20181218180747.GD18380@jcrouse-lnx.qualcomm.com> (raw)
In-Reply-To: <20181218172201.GA16590@bogus>
On Tue, Dec 18, 2018 at 11:22:01AM -0600, Rob Herring wrote:
> On Fri, Dec 14, 2018 at 03:16:39PM -0700, Jordan Crouse wrote:
> > Add documentation for the interconnect and interconnect-names bindings
> > for the GPU node as detailed by bindings/interconnect/interconnect.txt.
> >
> > Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
> > ---
> > Documentation/devicetree/bindings/display/msm/gpu.txt | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/msm/gpu.txt b/Documentation/devicetree/bindings/display/msm/gpu.txt
> > index 8d9415180c22..19b5ae459fdb 100644
> > --- a/Documentation/devicetree/bindings/display/msm/gpu.txt
> > +++ b/Documentation/devicetree/bindings/display/msm/gpu.txt
> > @@ -19,6 +19,9 @@ Required properties:
> > * "mem_iface"
> > - iommus: optional phandle to an adreno iommu instance
> > - operating-points-v2: optional phandle to the OPP operating points
> > +- interconnect: optional phandle to a interconnect provider. See
> > + ../interconnect/interconnect.txt for details.
> > +- interconnect-names: Name string for the interconnects.
> > - qcom,gmu: For a6xx and newer targets a phandle to the GMU device that will
> > control the power for the GPU
> >
> > @@ -68,6 +71,9 @@ Example a6xx (with GMU):
> >
> > operating-points-v2 = <&gpu_opp_table>;
> >
> > + interconnects = <&rsc_hlos MASTER_GFX3D &rsc_hlos SLAVE_EBI1>;
> > + interconnect-names = "gfx-mem";
>
> There's not really any point to having *-names when there is only 1
> value.
For the moment we can only look up the path from the DT by name. I guess we
could add an lookup by index but I'm not sure if that had already been
considered and rejected.
Jordan
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-18 18:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 22:16 [PATCH v2 0/2] arm64: dts: sdm845: Add sdm845 GPU interconnect Jordan Crouse
2018-12-14 22:16 ` [PATCH v2 1/2] dt-bindings: drm/msm/a6xx: Document interconnect properties for GPU Jordan Crouse
2018-12-14 23:58 ` Doug Anderson
2018-12-15 0:00 ` Doug Anderson
2018-12-18 17:22 ` Rob Herring
2018-12-18 18:07 ` Jordan Crouse [this message]
2018-12-18 21:01 ` Rob Herring
2018-12-14 22:16 ` [PATCH v2 2/2] arm64: dts: sdm845: Add interconnect " Jordan Crouse
2018-12-14 23:59 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218180747.GD18380@jcrouse-lnx.qualcomm.com \
--to=jcrouse@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rnayak@codeaurora.org \
--cc=robh@kernel.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).