linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	kernel@pengutronix.de, Fabio Estevam <fabio.estevam@nxp.com>,
	Robin Gong <yibin.gong@nxp.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] MAINTAINERS: add all files matching "imx" and "mxs" to the IMX entry
Date: Wed, 19 Dec 2018 12:15:04 +0800	[thread overview]
Message-ID: <20181219041502.GB13728@dragon> (raw)
In-Reply-To: <20181212090213.muqk53yr73h7qcup@pengutronix.de>

On Wed, Dec 12, 2018 at 10:02:13AM +0100, Uwe Kleine-König wrote:
...
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index b755a89fa325..cb9cbaa1ba19 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -1517,15 +1517,8 @@ R:	NXP Linux Team <linux-imx@nxp.com>
> > > >  L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> > > >  S:	Maintained
> > > >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git
> > > > -F:	arch/arm/mach-imx/
> > > > -F:	arch/arm/mach-mxs/
> > > > -F:	arch/arm/boot/dts/imx*
> > > > -F:	arch/arm/configs/imx*_defconfig
> > > > -F:	drivers/clk/imx/
> > > > -F:	drivers/firmware/imx/
> > > > -F:	drivers/soc/imx/
> > > > -F:	include/linux/firmware/imx/
> > > > -F:	include/soc/imx/
> > > > +N:	imx
> > > > +N:	mxs
> > > 
> > > This probably also matches drivers/media/i2c/*imx*, no?
> > 
> > Right, I didn't identify these as Sony stuff. Maybe NXP could sue them
> > to rename their products? :-)
> > 
> > So we need instead of
> > 
> > 	N: imx
> > 
> > better:
> > 
> > 	N: (?<!drivers/media/i2c/)imx
> > 
> > Or we add X: drivers/media/i2c/ ?
> 
> I didn't receive any feedback from you. Are you positive in general to
> let the IMX entry match all relevant drivers?

Yes.

> If yes, I'd respin this
> patch, probably using the more conservative "X: drivers/media/i2c"
> approach in stead of the negative look-behind trick.

We have some conflicting changes queued for merge window, so you may
want to rebase on 4.21-rc1.

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2018-12-19  4:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-22  7:57 [PATCH] MAINTAINERS: add all files matching "imx" and "mxs" to the IMX entry Uwe Kleine-König
2018-11-22  8:17 ` Robert Schwebel
2018-11-22  8:35   ` Uwe Kleine-König
2018-12-12  9:02     ` Uwe Kleine-König
2018-12-19  4:15       ` Shawn Guo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181219041502.GB13728@dragon \
    --to=shawnguo@kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=s.hauer@pengutronix.de \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=yibin.gong@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).