* [PATCH] MAINTAINERS: add all files matching "imx" and "mxs" to the IMX entry
@ 2018-11-22 7:57 Uwe Kleine-König
2018-11-22 8:17 ` Robert Schwebel
0 siblings, 1 reply; 5+ messages in thread
From: Uwe Kleine-König @ 2018-11-22 7:57 UTC (permalink / raw)
To: linux-arm-kernel
This way also the spi, i2c and other drivers are covered.
Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
---
Hello,
I was surprised by changes to the spi-imx driver[1]. To lessen the
chances that this happens again, I like making the IMX entry match all
relevant drivers.
Best regards
Uwe
[1] FTR: I didn't test yet, but I think
987a2dfe3f0485a82d87106e7e1c43f35c1d3b09 broke i.MX31 and i.MX35. Even
though a later patch made spi_imx_dma_transfer fail if .setup_wml isn't
provided, I guess this only changes from a NULL pointer exception to a
non-functional driver.
MAINTAINERS | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index b755a89fa325..cb9cbaa1ba19 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1517,15 +1517,8 @@ R: NXP Linux Team <linux-imx@nxp.com>
L: linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
S: Maintained
T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git
-F: arch/arm/mach-imx/
-F: arch/arm/mach-mxs/
-F: arch/arm/boot/dts/imx*
-F: arch/arm/configs/imx*_defconfig
-F: drivers/clk/imx/
-F: drivers/firmware/imx/
-F: drivers/soc/imx/
-F: include/linux/firmware/imx/
-F: include/soc/imx/
+N: imx
+N: mxs
ARM/FREESCALE VYBRID ARM ARCHITECTURE
M: Shawn Guo <shawnguo@kernel.org>
--
2.19.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] MAINTAINERS: add all files matching "imx" and "mxs" to the IMX entry
2018-11-22 7:57 [PATCH] MAINTAINERS: add all files matching "imx" and "mxs" to the IMX entry Uwe Kleine-König
@ 2018-11-22 8:17 ` Robert Schwebel
2018-11-22 8:35 ` Uwe Kleine-König
0 siblings, 1 reply; 5+ messages in thread
From: Robert Schwebel @ 2018-11-22 8:17 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Nov 22, 2018 at 08:57:42AM +0100, Uwe Kleine-K?nig wrote:
> This way also the spi, i2c and other drivers are covered.
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> I was surprised by changes to the spi-imx driver[1]. To lessen the
> chances that this happens again, I like making the IMX entry match all
> relevant drivers.
>
> Best regards
> Uwe
>
> [1] FTR: I didn't test yet, but I think
> 987a2dfe3f0485a82d87106e7e1c43f35c1d3b09 broke i.MX31 and i.MX35. Even
> though a later patch made spi_imx_dma_transfer fail if .setup_wml isn't
> provided, I guess this only changes from a NULL pointer exception to a
> non-functional driver.
>
> MAINTAINERS | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b755a89fa325..cb9cbaa1ba19 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1517,15 +1517,8 @@ R: NXP Linux Team <linux-imx@nxp.com>
> L: linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
> S: Maintained
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git
> -F: arch/arm/mach-imx/
> -F: arch/arm/mach-mxs/
> -F: arch/arm/boot/dts/imx*
> -F: arch/arm/configs/imx*_defconfig
> -F: drivers/clk/imx/
> -F: drivers/firmware/imx/
> -F: drivers/soc/imx/
> -F: include/linux/firmware/imx/
> -F: include/soc/imx/
> +N: imx
> +N: mxs
This probably also matches drivers/media/i2c/*imx*, no?
rsc
--
Pengutronix e.K. | Dipl.-Ing. Robert Schwebel |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] MAINTAINERS: add all files matching "imx" and "mxs" to the IMX entry
2018-11-22 8:17 ` Robert Schwebel
@ 2018-11-22 8:35 ` Uwe Kleine-König
2018-12-12 9:02 ` Uwe Kleine-König
0 siblings, 1 reply; 5+ messages in thread
From: Uwe Kleine-König @ 2018-11-22 8:35 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Nov 22, 2018 at 09:17:04AM +0100, Robert Schwebel wrote:
> On Thu, Nov 22, 2018 at 08:57:42AM +0100, Uwe Kleine-K?nig wrote:
> > This way also the spi, i2c and other drivers are covered.
> >
> > Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> > ---
> > Hello,
> >
> > I was surprised by changes to the spi-imx driver[1]. To lessen the
> > chances that this happens again, I like making the IMX entry match all
> > relevant drivers.
> >
> > Best regards
> > Uwe
> >
> > [1] FTR: I didn't test yet, but I think
> > 987a2dfe3f0485a82d87106e7e1c43f35c1d3b09 broke i.MX31 and i.MX35. Even
> > though a later patch made spi_imx_dma_transfer fail if .setup_wml isn't
> > provided, I guess this only changes from a NULL pointer exception to a
> > non-functional driver.
> >
> > MAINTAINERS | 11 ++---------
> > 1 file changed, 2 insertions(+), 9 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index b755a89fa325..cb9cbaa1ba19 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1517,15 +1517,8 @@ R: NXP Linux Team <linux-imx@nxp.com>
> > L: linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
> > S: Maintained
> > T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git
> > -F: arch/arm/mach-imx/
> > -F: arch/arm/mach-mxs/
> > -F: arch/arm/boot/dts/imx*
> > -F: arch/arm/configs/imx*_defconfig
> > -F: drivers/clk/imx/
> > -F: drivers/firmware/imx/
> > -F: drivers/soc/imx/
> > -F: include/linux/firmware/imx/
> > -F: include/soc/imx/
> > +N: imx
> > +N: mxs
>
> This probably also matches drivers/media/i2c/*imx*, no?
Right, I didn't identify these as Sony stuff. Maybe NXP could sue them
to rename their products? :-)
So we need instead of
N: imx
better:
N: (?<!drivers/media/i2c/)imx
Or we add X: drivers/media/i2c/ ?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MAINTAINERS: add all files matching "imx" and "mxs" to the IMX entry
2018-11-22 8:35 ` Uwe Kleine-König
@ 2018-12-12 9:02 ` Uwe Kleine-König
2018-12-19 4:15 ` Shawn Guo
0 siblings, 1 reply; 5+ messages in thread
From: Uwe Kleine-König @ 2018-12-12 9:02 UTC (permalink / raw)
To: Shawn Guo
Cc: Sascha Hauer, NXP Linux Team, kernel, Fabio Estevam, Robin Gong,
linux-arm-kernel
Hello Shawn,
On Thu, Nov 22, 2018 at 09:35:58AM +0100, Uwe Kleine-König wrote:
> On Thu, Nov 22, 2018 at 09:17:04AM +0100, Robert Schwebel wrote:
> > On Thu, Nov 22, 2018 at 08:57:42AM +0100, Uwe Kleine-König wrote:
> > > This way also the spi, i2c and other drivers are covered.
> > >
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > > ---
> > > Hello,
> > >
> > > I was surprised by changes to the spi-imx driver[1]. To lessen the
> > > chances that this happens again, I like making the IMX entry match all
> > > relevant drivers.
> > >
> > > Best regards
> > > Uwe
> > >
> > > [1] FTR: I didn't test yet, but I think
> > > 987a2dfe3f0485a82d87106e7e1c43f35c1d3b09 broke i.MX31 and i.MX35. Even
> > > though a later patch made spi_imx_dma_transfer fail if .setup_wml isn't
> > > provided, I guess this only changes from a NULL pointer exception to a
> > > non-functional driver.
> > >
> > > MAINTAINERS | 11 ++---------
> > > 1 file changed, 2 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index b755a89fa325..cb9cbaa1ba19 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -1517,15 +1517,8 @@ R: NXP Linux Team <linux-imx@nxp.com>
> > > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> > > S: Maintained
> > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git
> > > -F: arch/arm/mach-imx/
> > > -F: arch/arm/mach-mxs/
> > > -F: arch/arm/boot/dts/imx*
> > > -F: arch/arm/configs/imx*_defconfig
> > > -F: drivers/clk/imx/
> > > -F: drivers/firmware/imx/
> > > -F: drivers/soc/imx/
> > > -F: include/linux/firmware/imx/
> > > -F: include/soc/imx/
> > > +N: imx
> > > +N: mxs
> >
> > This probably also matches drivers/media/i2c/*imx*, no?
>
> Right, I didn't identify these as Sony stuff. Maybe NXP could sue them
> to rename their products? :-)
>
> So we need instead of
>
> N: imx
>
> better:
>
> N: (?<!drivers/media/i2c/)imx
>
> Or we add X: drivers/media/i2c/ ?
I didn't receive any feedback from you. Are you positive in general to
let the IMX entry match all relevant drivers? If yes, I'd respin this
patch, probably using the more conservative "X: drivers/media/i2c"
approach in stead of the negative look-behind trick.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MAINTAINERS: add all files matching "imx" and "mxs" to the IMX entry
2018-12-12 9:02 ` Uwe Kleine-König
@ 2018-12-19 4:15 ` Shawn Guo
0 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2018-12-19 4:15 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Sascha Hauer, NXP Linux Team, kernel, Fabio Estevam, Robin Gong,
linux-arm-kernel
On Wed, Dec 12, 2018 at 10:02:13AM +0100, Uwe Kleine-König wrote:
...
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index b755a89fa325..cb9cbaa1ba19 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -1517,15 +1517,8 @@ R: NXP Linux Team <linux-imx@nxp.com>
> > > > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
> > > > S: Maintained
> > > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git
> > > > -F: arch/arm/mach-imx/
> > > > -F: arch/arm/mach-mxs/
> > > > -F: arch/arm/boot/dts/imx*
> > > > -F: arch/arm/configs/imx*_defconfig
> > > > -F: drivers/clk/imx/
> > > > -F: drivers/firmware/imx/
> > > > -F: drivers/soc/imx/
> > > > -F: include/linux/firmware/imx/
> > > > -F: include/soc/imx/
> > > > +N: imx
> > > > +N: mxs
> > >
> > > This probably also matches drivers/media/i2c/*imx*, no?
> >
> > Right, I didn't identify these as Sony stuff. Maybe NXP could sue them
> > to rename their products? :-)
> >
> > So we need instead of
> >
> > N: imx
> >
> > better:
> >
> > N: (?<!drivers/media/i2c/)imx
> >
> > Or we add X: drivers/media/i2c/ ?
>
> I didn't receive any feedback from you. Are you positive in general to
> let the IMX entry match all relevant drivers?
Yes.
> If yes, I'd respin this
> patch, probably using the more conservative "X: drivers/media/i2c"
> approach in stead of the negative look-behind trick.
We have some conflicting changes queued for merge window, so you may
want to rebase on 4.21-rc1.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-12-19 4:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-22 7:57 [PATCH] MAINTAINERS: add all files matching "imx" and "mxs" to the IMX entry Uwe Kleine-König
2018-11-22 8:17 ` Robert Schwebel
2018-11-22 8:35 ` Uwe Kleine-König
2018-12-12 9:02 ` Uwe Kleine-König
2018-12-19 4:15 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).