From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E08EC43387 for ; Wed, 19 Dec 2018 09:21:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFF85217D9 for ; Wed, 19 Dec 2018 09:21:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XhX607sX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="QiIHkgYb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFF85217D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ca3Jc0NaaRf/6JBDQQD1EQ1Hk/BtufutPJ4QR8e4jxc=; b=XhX607sXhJDDdO ZbIIPg77ufeTiZjDbdoRDeJpq7VLg81RxKFwF48d39+lzEsjvigU3ni7vn8YsZPYhroGXK5skpQck xpi7BJ3cpuppzqFUe3ZSWtsEzEWaynardcbrE7SJd215XoP/QzxsLtIfRTi46WozLnSbc8asNcF/x J1FtBULYDY8Wdd8m+sHJdpKrMgINl6hBifYCJ/MStm4usr+6gZC+N7i3WRDjq/UXIsY2+1UH4pwLm DjN0jtMmoh+CS5pPKzRqe50HS/1FakomiS6TAvz04dCDFoHHM8w0pGxAjgQ3k1VYTsvJcmYoXBObV oLAX5zSeZija7IDJ1P1g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gZY2b-0003eD-VA; Wed, 19 Dec 2018 09:21:21 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gZY2X-0003cj-Pb for linux-arm-kernel@lists.infradead.org; Wed, 19 Dec 2018 09:21:19 +0000 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7FE95217D9; Wed, 19 Dec 2018 09:21:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545211267; bh=H064+QOZvPRnogqHQtVDmtqaJyeWrB0GMpAxGBHzdIE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QiIHkgYbleSym9Tt7PmUp45uyopsaqT9AmhPWjMH44yaCz6KJVYvbI+QhHmCqszTt +V+Vrxi/+A2kaSE2KFGtb+UQU5fp9D/VWlCvq0Ahrxyv5U5pHHMo9/YhqwUS/Lr0ck 31MiOffLfOgX3zoAO0AFYbRFvaHF17TrUVco1Tuo= Date: Wed, 19 Dec 2018 10:21:04 +0100 From: Greg KH To: Xiaowei Bao Subject: Re: [PATCHv3 4/4] misc: pci_endpoint_test: Add the layerscape EP device support Message-ID: <20181219092104.GA7356@kroah.com> References: <20181203103505.46885-1-xiaowei.bao@nxp.com> <20181203103505.46885-4-xiaowei.bao@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181203103505.46885-4-xiaowei.bao@nxp.com> User-Agent: Mutt/1.11.1 (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181219_012117_852097_1A927531 X-CRM114-Status: GOOD ( 15.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, roy.zang@nxp.com, lorenzo.pieralisi@arm.com, arnd@arndb.de, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, kstewart@linuxfoundation.org, niklas.cassel@axis.com, linux-kernel@vger.kernel.org, kishon@ti.com, minghuan.Lian@nxp.com, robh+dt@kernel.org, cyrille.pitchen@free-electrons.com, linux-arm-kernel@lists.infradead.org, pombredanne@nexb.com, bhelgaas@google.com, leoyang.li@nxp.com, shawnguo@kernel.org, shawn.lin@rock-chips.com, mingkai.hu@nxp.com, linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 03, 2018 at 06:35:05PM +0800, Xiaowei Bao wrote: > Add the layerscape EP device support in pci_endpoint_test driver. > > Signed-off-by: Xiaowei Bao > --- > v2: > - no change > v3: > - no change > > drivers/misc/pci_endpoint_test.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c > index 896e2df..744d10c 100644 > --- a/drivers/misc/pci_endpoint_test.c > +++ b/drivers/misc/pci_endpoint_test.c > @@ -788,6 +788,8 @@ static void pci_endpoint_test_remove(struct pci_dev *pdev) > static const struct pci_device_id pci_endpoint_test_tbl[] = { > { PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA74x) }, > { PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA72x) }, > + /* 0x81c0: The device id of ls1046a in NXP. */ There is no need for a comment, just this line is fine: > + { PCI_DEVICE(PCI_VENDOR_ID_FREESCALE, 0x81c0) }, If you note, no other lines have comments. If you want to say that this is a specific device, then use a #define with that device name and then use that define here, like the PCI_DEVICE_ID_TI_DRA72x was done. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel