From: Christoph Hellwig <hch@lst.de>
To: Huang Shijie <sjhuang@iluvatar.ai>
Cc: sfr@canb.auug.org.au, arnd@arndb.de, gregkh@linuxfoundation.org,
linux@armlinux.org.uk, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, shijie8@gmail.com,
akpm@linux-foundation.org, robin.murphy@arm.com, hch@lst.de,
linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com
Subject: Re: [PATCH] lib/genalloc.c: rename addr_in_gen_pool to gen_pool_has_addr
Date: Fri, 28 Dec 2018 09:48:34 +0100 [thread overview]
Message-ID: <20181228084834.GA8658@lst.de> (raw)
In-Reply-To: <20181228083950.20398-1-sjhuang@iluvatar.ai>
On Fri, Dec 28, 2018 at 04:39:50PM +0800, Huang Shijie wrote:
> Follow the kernel conventions, rename addr_in_gen_pool to
> gen_pool_has_addr.
Which convention? The old name certainly looks more sensible to me.
If we really want to change anything about this function I'd suggest
to drop the size argument, as the address itself should describe the
region good enough.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-28 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-28 8:39 [PATCH] lib/genalloc.c: rename addr_in_gen_pool to gen_pool_has_addr Huang Shijie
2018-12-28 8:48 ` Christoph Hellwig [this message]
2018-12-28 9:17 ` Huang Shijie
2018-12-28 23:39 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181228084834.GA8658@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=sfr@canb.auug.org.au \
--cc=shijie8@gmail.com \
--cc=sjhuang@iluvatar.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox