* [PATCH -next] hwspinlock: fix return value check in stm32_hwspinlock_probe()
@ 2019-01-03 7:02 Wei Yongjun
2019-01-03 10:06 ` Benjamin GAIGNARD
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2019-01-03 7:02 UTC (permalink / raw)
To: Ohad Ben-Cohen, Bjorn Andersson, Maxime Coquelin,
Alexandre Torgue, Benjamin Gaignard
Cc: linux-remoteproc, kernel-janitors, Wei Yongjun, linux-stm32,
linux-arm-kernel
In case of error, the function devm_ioremap_resource() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().
Fixes: f24fcff1d267 ("hwspinlock: add STM32 hwspinlock device")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/hwspinlock/stm32_hwspinlock.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hwspinlock/stm32_hwspinlock.c b/drivers/hwspinlock/stm32_hwspinlock.c
index 34a8e00..4418392 100644
--- a/drivers/hwspinlock/stm32_hwspinlock.c
+++ b/drivers/hwspinlock/stm32_hwspinlock.c
@@ -57,8 +57,8 @@ static int stm32_hwspinlock_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
io_base = devm_ioremap_resource(&pdev->dev, res);
- if (!io_base)
- return -ENOMEM;
+ if (IS_ERR(io_base))
+ return PTR_ERR(io_base);
array_size = STM32_MUTEX_NUM_LOCKS * sizeof(struct hwspinlock);
hw = devm_kzalloc(&pdev->dev, sizeof(*hw) + array_size, GFP_KERNEL);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] hwspinlock: fix return value check in stm32_hwspinlock_probe()
2019-01-03 7:02 [PATCH -next] hwspinlock: fix return value check in stm32_hwspinlock_probe() Wei Yongjun
@ 2019-01-03 10:06 ` Benjamin GAIGNARD
2019-01-03 20:07 ` Bjorn Andersson
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin GAIGNARD @ 2019-01-03 10:06 UTC (permalink / raw)
To: Wei Yongjun, Ohad Ben-Cohen, Bjorn Andersson, Maxime Coquelin,
Alexandre TORGUE
Cc: kernel-janitors@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
On 1/3/19 8:02 AM, Wei Yongjun wrote:
> In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
>
> Fixes: f24fcff1d267 ("hwspinlock: add STM32 hwspinlock device")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Benjamin Gaignard <benjamin.gaignard@gmail.com>
> ---
> drivers/hwspinlock/stm32_hwspinlock.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwspinlock/stm32_hwspinlock.c b/drivers/hwspinlock/stm32_hwspinlock.c
> index 34a8e00..4418392 100644
> --- a/drivers/hwspinlock/stm32_hwspinlock.c
> +++ b/drivers/hwspinlock/stm32_hwspinlock.c
> @@ -57,8 +57,8 @@ static int stm32_hwspinlock_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> io_base = devm_ioremap_resource(&pdev->dev, res);
> - if (!io_base)
> - return -ENOMEM;
> + if (IS_ERR(io_base))
> + return PTR_ERR(io_base);
>
> array_size = STM32_MUTEX_NUM_LOCKS * sizeof(struct hwspinlock);
> hw = devm_kzalloc(&pdev->dev, sizeof(*hw) + array_size, GFP_KERNEL);
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] hwspinlock: fix return value check in stm32_hwspinlock_probe()
2019-01-03 10:06 ` Benjamin GAIGNARD
@ 2019-01-03 20:07 ` Bjorn Andersson
0 siblings, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2019-01-03 20:07 UTC (permalink / raw)
To: Benjamin GAIGNARD
Cc: Ohad Ben-Cohen, Alexandre TORGUE, kernel-janitors@vger.kernel.org,
linux-remoteproc@vger.kernel.org, Wei Yongjun, Maxime Coquelin,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
On Thu 03 Jan 02:06 PST 2019, Benjamin GAIGNARD wrote:
>
> On 1/3/19 8:02 AM, Wei Yongjun wrote:
> > In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> > and never returns NULL. The NULL test in the return value check should
> > be replaced with IS_ERR().
> >
> > Fixes: f24fcff1d267 ("hwspinlock: add STM32 hwspinlock device")
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Acked-by: Benjamin Gaignard <benjamin.gaignard@gmail.com>
Thanks for the fix and the review!
Regards,
Bjorn
> > ---
> > drivers/hwspinlock/stm32_hwspinlock.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/hwspinlock/stm32_hwspinlock.c b/drivers/hwspinlock/stm32_hwspinlock.c
> > index 34a8e00..4418392 100644
> > --- a/drivers/hwspinlock/stm32_hwspinlock.c
> > +++ b/drivers/hwspinlock/stm32_hwspinlock.c
> > @@ -57,8 +57,8 @@ static int stm32_hwspinlock_probe(struct platform_device *pdev)
> >
> > res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > io_base = devm_ioremap_resource(&pdev->dev, res);
> > - if (!io_base)
> > - return -ENOMEM;
> > + if (IS_ERR(io_base))
> > + return PTR_ERR(io_base);
> >
> > array_size = STM32_MUTEX_NUM_LOCKS * sizeof(struct hwspinlock);
> > hw = devm_kzalloc(&pdev->dev, sizeof(*hw) + array_size, GFP_KERNEL);
> >
> >
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-03 20:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-03 7:02 [PATCH -next] hwspinlock: fix return value check in stm32_hwspinlock_probe() Wei Yongjun
2019-01-03 10:06 ` Benjamin GAIGNARD
2019-01-03 20:07 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).